-
Notifications
You must be signed in to change notification settings - Fork 52
FEAT: Add to_dict(), keys(), values(), items(), __contains__ to Row #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jahnvi Thakkar (jahnvi480)
wants to merge
18
commits into
main
Choose a base branch
from
jahnvi/row-dict-api-606
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+265
−65
Open
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a4852ad
FEAT: Add to_dict(), keys(), values(), items(), __contains__ to Row (…
jahnvi480 d21846e
FIX: Deduplicate dict-like methods when _column_map has lowercase ali…
jahnvi480 757a550
Linting fix
jahnvi480 a4804ae
Merge branch 'main' into jahnvi/row-dict-api-606
jahnvi480 9b96304
Merge branch 'main' into jahnvi/row-dict-api-606
jahnvi480 75998e2
FIX: Move _column_names to cursor for zero per-row cost, fix items() …
jahnvi480 31f3d47
REFACTOR: Move all Row tests from globals to cursor integration tests
jahnvi480 89c3b2f
FIX: Correct test_row_case_insensitive_access - normal SELECT has no …
jahnvi480 b7cb1a8
Merge branch 'main' into jahnvi/row-dict-api-606
jahnvi480 0917d1f
TEST: Cover _column_names=() and __contains__ lowercase branches (lin…
jahnvi480 93d9f37
Resolving linting issue
jahnvi480 c2c6927
PERF: Lazy-compute _column_names, add type annotations, update class …
jahnvi480 ae22ff8
Merge branch 'main' into jahnvi/row-dict-api-606
jahnvi480 e6142d0
TEST: Cover _get_column_names dedup fallback (lines 228-232)
jahnvi480 04111b9
FIX: Remove __contains__ (breaking change), make values() return tupl…
jahnvi480 10292eb
Merge branch 'main' into jahnvi/row-dict-api-606
jahnvi480 a4b4ac2
Merge branch 'main' into jahnvi/row-dict-api-606
jahnvi480 fa3c112
Merge branch 'main' into jahnvi/row-dict-api-606
jahnvi480 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.