Resolve poetry failure on a secondary repo#1132
Merged
kuqin12 merged 31 commits intomicrosoft:feature/ffa_enablementfrom May 8, 2025
Merged
Resolve poetry failure on a secondary repo#1132kuqin12 merged 31 commits intomicrosoft:feature/ffa_enablementfrom
kuqin12 merged 31 commits intomicrosoft:feature/ffa_enablementfrom
Conversation
github-actions
bot
added
the
language:python
github-actions
bot
added
the
impact:non-functional
Raymond-MS
reviewed
Mar 25, 2025
Contributor
|
I don't feel super comfortable signing off on these changes as I don't understand them well enough. Would it be okay if you pulled in another reviewer to take a look as well? As far as I can tell the changes look okay but I don't have the experience in this to confirm there are no issues. |
Raymond-MS
approved these changes
Mar 25, 2025
Contributor
Raymond-MS
left a comment
Raymond-MS
left a comment
There was a problem hiding this comment.
LGTM, but I would like another pair of eyes if possible. :)
apop5
approved these changes
Apr 1, 2025
kuqin12
merged commit 6f60ca6
into
microsoft:feature/ffa_enablement
7 of 10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change intends to setup poetry environments for the TFA build process.
How This Was Tested
This change is tested locally.
Integration Instructions
N/A