QemuSbsaPkg: Add toggle for Windows support (#223)#1388
Merged
Javagedes merged 1 commit intomicrosoft:mainfrom Apr 6, 2026
Merged
QemuSbsaPkg: Add toggle for Windows support (#223)#1388Javagedes merged 1 commit intomicrosoft:mainfrom
Javagedes merged 1 commit intomicrosoft:mainfrom
Conversation
When HAF / TF-A source code is updated, there is a period of at least one commit where the source code and binary external dependency are out of sync. In this scenario, the platform must compile the HAF / TF-A binaries locally, otherwise unexpected behavior may occur. This commit enforces that requirement with the caveat that building HAF / TF-A is not supported on windows, so we instead log a warning and abort the build. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? Ran CI with `HAF_TFA_EXTDEP_BINS_CURRENT` set to True and False to ensure builds are aborted when expected and fully executed otherwise. N/A
kuqin12
approved these changes
Apr 6, 2026
makubacki
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When HAF / TF-A source code is updated, there is a period of at least one commit where the source code and binary external dependency are out of sync. In this scenario, the platform must compile the HAF / TF-A binaries locally, otherwise unexpected behavior may occur.
This commit enforces that requirement with the caveat that building HAF / TF-A is not supported on windows, so we instead log a warning and abort the build.
How This Was Tested
Ran CI with
HAF_TFA_EXTDEP_BINS_CURRENTset to True and False to ensure builds are aborted when expected and fully executed otherwise.Integration Instructions
N/A