Skip to content

fix(page): collect DOM elements retained by locator hit-target interceptor #41575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgozman merged 9 commits into from
Jul 13, 2026
+15 −1
Merged

fix(page): collect DOM elements retained by locator hit-target interceptor #41575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b58a32b
fix(hit target): release hit-target interceptor closure to allow GC o…
Zelys-DFKH Jun 29, 2026
4c98845
fix(page): clear Blink hit-target state before requestGC
Zelys-DFKH Jun 30, 2026
ce12be5
fix(page): explain requestGC's hit-target workaround via Blink's node…
Zelys-DFKH Jul 1, 2026
62c60e1
fix(page): drop unverified Blink internals from requestGC comment
Zelys-DFKH Jul 1, 2026
94e13b0
test: mark Firefox hit-target interceptor GC test as fixme
Zelys-DFKH Jul 3, 2026
ab382d2
Revert "fix(page): drop unverified Blink internals from requestGC com…
Zelys-DFKH Jul 10, 2026
2895b03
Revert "fix(page): explain requestGC's hit-target workaround via Blin…
Zelys-DFKH Jul 10, 2026
3149c13
Revert "fix(page): clear Blink hit-target state before requestGC"
Zelys-DFKH Jul 10, 2026
dff3919
test: mark Chromium hit-target interceptor GC test as fixme pending u…
Zelys-DFKH Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/injected/src/injectedScript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1113,7 +1113,7 @@ export class InjectedScript {
}[action];
let result: 'done' | { hitTargetDescription: string } | undefined;

const listener = (event: PointerEvent | MouseEvent | TouchEvent) => {
let listener: ((event: PointerEvent | MouseEvent | TouchEvent) => void) | undefined = (event: PointerEvent | MouseEvent | TouchEvent) => {
// Ignore events that we do not expect to intercept.
if (!events.has(event.type))
return;
Expand Down Expand Up @@ -1142,6 +1142,7 @@ export class InjectedScript {
const stop = () => {
if (this._hitTargetInterceptor === listener)
this._hitTargetInterceptor = undefined;
listener = undefined;

@pavelfeldman pavelfeldman Jul 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

// If we did not get any events, consider things working. Possible causes:
// - JavaScript is disabled (webkit-only).
// - Some <iframe> overlays the element from another frame.
Expand Down
13 changes: 13 additions & 0 deletions tests/page/page-request-gc.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,16 @@ test('should work', async ({ page }) => {
await page.requestGC();
expect(await page.evaluate(() => globalThis.weakRef.deref())).toBe(undefined);
});

test('should collect element retained by locator hit-target interceptor after detach', async ({ page, browserName }) => {
test.fixme(browserName === 'firefox', 'Firefox hit-target interceptor does not release its element reference on detach');
test.fixme(browserName === 'chromium', 'Chromium retains a native reference to the last hit-tested element; fix pending upstream discussion, see #41575');
await page.setContent('<button id="btn">click me</button>');
await page.locator('#btn').click();
await page.evaluate(() => {
globalThis.weakRef = new WeakRef(document.getElementById('btn')!);
document.getElementById('btn')!.remove();
});
await page.requestGC();
expect(await page.evaluate(() => globalThis.weakRef.deref())).toBe(undefined);
});
Loading