Skip to content

Move definiteAssignmentAssertionsWithObjectShortHand.js.diff file to accepted#3993

Merged
ahejlsberg merged 1 commit into
mainfrom
fix-3563
May 20, 2026
Merged

Move definiteAssignmentAssertionsWithObjectShortHand.js.diff file to accepted#3993
ahejlsberg merged 1 commit into
mainfrom
fix-3563

Conversation

@ahejlsberg
Copy link
Copy Markdown
Member

Fixes #3563.

Copilot AI review requested due to automatic review settings May 19, 2026 19:46
@ahejlsberg ahejlsberg changed the title Move .diff file to accepted Move definiteAssignmentAssertionsWithObjectShortHand.js.diff file to accepted May 19, 2026
@ahejlsberg ahejlsberg requested a review from RyanCavanaugh May 19, 2026 19:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Moves the definiteAssignmentAssertionsWithObjectShortHand.js.diff entry from the triaged list to the accepted list, reflecting resolution of issue #3563.

Changes:

  • Removed entry for issue #3563 from submoduleTriaged.txt
  • Added the same entry to submoduleAccepted.txt

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
testdata/submoduleTriaged.txt Removed the triaged entry for issue #3563
testdata/submoduleAccepted.txt Added the accepted entry for issue #3563

@ahejlsberg ahejlsberg added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit 196800c May 20, 2026
25 checks passed
@ahejlsberg ahejlsberg deleted the fix-3563 branch May 20, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Baselines: definiteAssignment shorthand in object literal loses optional modifier

3 participants