Extract tscInput tests to individual per-scenario files with imperative edits to improve debuggability#3996
Open
weswigham wants to merge 1 commit into
Open
Extract tscInput tests to individual per-scenario files with imperative edits to improve debuggability#3996weswigham wants to merge 1 commit into
weswigham wants to merge 1 commit into
Conversation
…ve edits to improve debuggability
Member
|
Not sure I like this, but at the very least I think the filenames shouldn't start with capital T |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And also remove some intra-test parallelism. The tests are parallel. The compilation in the test may be parallel. The assertions within the test do not need to be parallel. It's just extra indirection to try and step/break into.
The original tests technically still exist if you prefer writing/debugging those (for some reason), so the tests are run twice (and the logic generating the new test formulation is still hooked into the old style tests to continuously emit a copy into the new style), but this formulation is leagues easier to step into/through what individual edits are actually doing by eliminating the whole "test generation" part of tests.