fix: add a View menu command to restore the server window sidebar#73
Open
mvanhorn wants to merge 1 commit into
Open
fix: add a View menu command to restore the server window sidebar#73mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a View menu command to restore the server window sidebar.
Why this matters
In the macOS Hotline client, a user (jhalter) dragged the server window's left sidebar
fully closed and could not get it back. The owner (mierau) explained that he deliberately
removes the sidebar toggle button from the toolbar (
.toolbar(removing: .sidebarToggle)in
ServerView.swift), so once the sidebar is collapsed there is no discoverable controlto reopen it. The
⌘⌥Sshortcut still toggles it, but there is no visible menu affordance,and the collapsed state persists across app restarts. The owner explicitly said he would
"take a look at adding a menu item to the view menu or something" - this issue is the
request for that discoverable, always-available restore control. He does not
Testing
Changes are scoped to the files named in the fix; added or updated tests where the project has a suite, and matched existing conventions.
Fixes #55