Skip to content

xml-parser.parseResponseError(): return parsed error instead of throwing#1401

Open
alxndrsn wants to merge 1 commit intominio:masterfrom
alxndrsn:parse-error-dont-throw-error
Open

xml-parser.parseResponseError(): return parsed error instead of throwing#1401
alxndrsn wants to merge 1 commit intominio:masterfrom
alxndrsn:parse-error-dont-throw-error

Conversation

@alxndrsn
Copy link
Copy Markdown
Contributor

@alxndrsn alxndrsn commented Apr 3, 2025

Closes #1400

@alxndrsn alxndrsn mentioned this pull request Apr 3, 2025
Open
@prakashsvmx
Copy link
Copy Markdown
Member

prakashsvmx commented Apr 7, 2025

could you please fix the lint errors @alxndrsn ?

@alxndrsn
Copy link
Copy Markdown
Contributor Author

alxndrsn commented Apr 7, 2025

could you please fix the lint errors @alxndrsn ?

Sure. How would you recommend resolving the type errors? Should errors in parseError() and parseResponseError() be typed as Error, Record<string, string>, Record<string, unknown>, or something else?

@prakashsvmx
Copy link
Copy Markdown
Member

prakashsvmx commented Apr 30, 2025

not sure, i have not found a strongly typed type for this , but we can improve progressively

@alxndrsn
Copy link
Copy Markdown
Contributor Author

alxndrsn commented Apr 30, 2025

Should I just add anys until lint passes?

@prakashsvmx
Copy link
Copy Markdown
Member

prakashsvmx commented Jul 21, 2025

you could explore casting, composite type etc @alxndrsn

@alxndrsn
Copy link
Copy Markdown
Contributor Author

alxndrsn commented Jul 29, 2025

you could explore casting, composite type etc @alxndrsn

👍 Do you think errors in parseError() and parseResponseError() be typed as Error, Record<string, string>, Record<string, unknown>, or something else?

@alxndrsn
Copy link
Copy Markdown
Contributor Author

alxndrsn commented Mar 29, 2026

Do you think errors in parseError() and parseResponseError() be typed as Error, Record<string, string>, Record<string, unknown>, or something else?

@prakashsvmx any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dead code in makeRequestStreamAsync()?

2 participants

@alxndrsn @prakashsvmx