Open
Conversation
Owner
|
This solution to rotate the keys puts the onus on the developers with no mechanism for enforcement/compliance. |
miztiik
reviewed
May 11, 2019
Owner
miztiik
left a comment
miztiik
left a comment
There was a problem hiding this comment.
I have added some inline comments, Can you please review them add/fix them.
miztiik
requested changes
May 11, 2019
Owner
miztiik
left a comment
miztiik
left a comment
There was a problem hiding this comment.
Getting used to the review functionality,
This package cannot be enforced upon all dev's. For an enterprise, enforcing this and relying solely on dev discretion is not the best way to rotate keys.
Do you have any other recommendations for key rotation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.