Skip to content

Use chrono types for improved datetime handling#139

Merged
andschneider merged 2 commits intomainfrom
datetime-cleanup
Apr 28, 2026
Merged

Use chrono types for improved datetime handling#139
andschneider merged 2 commits intomainfrom
datetime-cleanup

Conversation

@andschneider
Copy link
Copy Markdown
Collaborator

@andschneider andschneider commented Apr 28, 2026

  • datetime handling was all over the place
  • this improves it by moving API models from string dates to strongly typed chrono::NaiveDate and chrono::DateTime fields
  • additionally, centralized all date related helper functions, which are now just formatters (instead of also being parsers)

@andschneider andschneider merged commit ef5b9c8 into main Apr 28, 2026
3 checks passed
@andschneider andschneider deleted the datetime-cleanup branch April 28, 2026 07:01
agiacalone added a commit to agiacalone/mlbtg that referenced this pull request Apr 29, 2026
@agiacalone
Merge upstream/main: chrono datetime, stats sort prefs, final pitchers
e56e181 
Pulls in upstream commits cec79a4..fe7c624:

- Bump Rust to 1.95 (mlb-rs#135)
- Allow wrapping on help text scroll (mlb-rs#136)
- Stats: all/qualified toggle and persist sort preferences (mlb-rs#137)
- Show winning/losing/save pitcher for final games (mlb-rs#138)
- Use chrono types for improved datetime handling (mlb-rs#139)
- Stop cargo test from overwriting mlbt.toml (mlb-rs#140)

Conflict resolutions kept the fork's identity (mlbtg name/version, both
authors, fork-targeted Docker labels) and visual additions: Theme::DIMMED
in place of upstream's DIM_COLOR; selection_style/title_style in place of
upstream's HIGHLIGHT_STYLE; full obp/slg/ops/whip column color helpers;
team_color is_win tuple in team page; symbols param on
draw_linescore_boxscore alongside upstream's decision_pitchers plumbing.
game_log_cells now uses format_numeric_date_or (format_date removed).

Also adds CLAUDE.md and updates README/CHANGELOG with merged entries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@andschneider