Refactor all styling and color handling#141
Merged
andschneider merged 10 commits intomainfrom Apr 30, 2026
Merged
Conversation
Realized this should not be set by changing the text color, but by using a modifier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Styling and colors were set individually in each component. This led to inconsistencies in things like borders and some text. Additionally, dimmed text was done incorrectly by just using a dark grey color instead of the
Modifier::DIM. This fixes those problems and centralizes styling for borders, table highlights, and table headers.This wasn't a problem for most dark themes, however for light themes the TUI was unusable. By changing to the default color for text the terminal's own theme can set it.
Also, this enables adding themes pretty trivially in the future.