Skip to content

fix(feedback): add error handling for modal feedback submission #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SebConejo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(feedback): add error handling for modal feedback submission #1611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bed3cb
fix(feedback): add error handling for modal feedback submission
SebConejo Apr 18, 2026
fc4926c
test: cover modal submit feedback API error path
SebConejo Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/frontend/src/pages/MessageLog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,13 @@ const MessageLog: Component = () => {
const handleFeedbackSubmit = (tags: string[], details: string) => {
const id = feedbackMessageId();
if (id) {
setMessageFeedback(id, { rating: 'dislike', tags, details });
setMessageFeedback(id, { rating: 'dislike', tags, details }).catch(() => {
setFeedbackOverrides((prev) => {
const next = { ...prev };
delete next[id];
return next;
});
});
}
setFeedbackModalOpen(false);
};
Expand Down
8 changes: 7 additions & 1 deletion packages/frontend/src/pages/Overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,13 @@ const Overview: Component = () => {
const handleFeedbackSubmit = (tags: string[], details: string) => {
const id = feedbackMessageId();
if (id) {
setMessageFeedback(id, { rating: 'dislike', tags, details });
setMessageFeedback(id, { rating: 'dislike', tags, details }).catch(() => {
setFeedbackOverrides((prev) => {
const next = { ...prev };
delete next[id];
return next;
});
});
}
setFeedbackModalOpen(false);
};
Expand Down
18 changes: 18 additions & 0 deletions packages/frontend/tests/pages/MessageLog.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,6 +934,24 @@ describe("MessageLog", () => {
expect(mockSetMessageFeedback).toHaveBeenCalledWith("msg-12345678", { rating: "dislike", tags: ["Too slow"], details: "test" });
});

it("reverts optimistic dislike when modal submit API call fails", async () => {
mockSetMessageFeedback
.mockResolvedValueOnce(undefined) // dislike click succeeds
.mockRejectedValueOnce(new Error("fail")); // modal submit fails
mockGetMessages.mockResolvedValue(messagesData);
const { container } = render(() => <MessageLog />);
await vi.waitFor(() => {
expect(container.querySelector(".feedback-btn")).not.toBeNull();
});
const dislikeBtn = container.querySelectorAll(".feedback-btn")[1] as HTMLElement;
fireEvent.click(dislikeBtn);
const submitBtn = container.querySelector('[data-testid="feedback-submit"]') as HTMLElement;
fireEvent.click(submitBtn);
await vi.waitFor(() => {
expect(container.querySelector(".feedback-btn--active-dislike")).toBeNull();
});
});

it("closes feedback modal without submitting", async () => {
mockSetMessageFeedback.mockResolvedValue(undefined);
mockGetMessages.mockResolvedValue(messagesData);
Expand Down
18 changes: 18 additions & 0 deletions packages/frontend/tests/pages/Overview.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,6 +868,24 @@ describe("Overview", () => {
expect(mockSetMessageFeedback).toHaveBeenCalledWith("msg-12345678", { rating: "dislike", tags: ["Too slow"], details: "test" });
});

it("reverts optimistic dislike when modal submit API call fails", async () => {
mockSetMessageFeedback
.mockResolvedValueOnce(undefined) // dislike click succeeds
.mockRejectedValueOnce(new Error("fail")); // modal submit fails
mockGetOverview.mockResolvedValue(overviewData);
const { container } = render(() => <Overview />);
await vi.waitFor(() => {
expect(container.querySelector(".feedback-btn")).not.toBeNull();
});
const dislikeBtn = container.querySelectorAll(".feedback-btn")[1] as HTMLElement;
fireEvent.click(dislikeBtn);
const submitBtn = container.querySelector('[data-testid="feedback-submit"]') as HTMLElement;
fireEvent.click(submitBtn);
await vi.waitFor(() => {
expect(container.querySelector(".feedback-btn--active-dislike")).toBeNull();
});
});

it("hides feedback column and modal in local mode", async () => {
mockCheckIsLocalMode.mockResolvedValue(true);
mockGetOverview.mockResolvedValue(overviewData);
Expand Down
Loading