feat: print each error within AggregateErrors - #6120
Open
gaurav0107 wants to merge 1 commit into
Open
Conversation
getFullErrorStack now traverses err.errors so the reporters append each error contained in an AggregateError (message + stack), reusing the same recursive formatting as the existing err.cause trail. Non-Error entries are stringified and circular references are guarded via the shared seen set. Fixes mochajs#4982
gaurav0107
marked this pull request as ready for review
June 28, 2026 21:17
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6120 +/- ##
==========================================
+ Coverage 82.38% 82.42% +0.03%
==========================================
Files 61 61
Lines 4564 4574 +10
Branches 958 964 +6
==========================================
+ Hits 3760 3770 +10
Misses 804 804 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
When a test throws an
AggregateError, reporters only printed the top-level message and stack; the individual errors inerror.errorswere dropped. This extendsgetFullErrorStackinlib/reporters/base.jsto traverseerr.errorsand append each contained error (message + stack), reusing the same recursive formatting as the existingerr.causetrail.causechains inside aggregated errors render via the same recursion.Errorentries (anAggregateErrormay be constructed with any iterable) are stringified rather than crashing the reporter.seenset.Output for an
AggregateError:Unit tests added in
test/reporters/base.spec.cjscover multiple/single/non-Error/nested/circular cases.