Deprecate roots, sampling, and logging per SEP-2577#406
Open
atesgoral wants to merge 1 commit into
Open
Conversation
atesgoral
force-pushed
the
issue-390-deprecations
branch
4 times, most recently
from
d8066ae to
6cabe09
Compare
atesgoral
changed the base branch from
main
to
rubocop-cleanup-existing-offenses
atesgoral
force-pushed
the
rubocop-cleanup-existing-offenses
branch
from
0e694e3 to
460adaf
Compare
atesgoral
force-pushed
the
issue-390-deprecations
branch
2 times, most recently
from
26a27ad to
9533204
Compare
atesgoral
changed the base branch from
rubocop-cleanup-existing-offenses
to
main
atesgoral
force-pushed
the
issue-390-deprecations
branch
4 times, most recently
from
3f8cf4a to
0c7a871
Compare
Warn when Roots, Sampling, or Logging APIs are used with MCP protocol version 2026-07-28, while leaving the latest stable default at 2025-11-25. Add a shared protocol deprecation helper, YARD deprecation notes, and regression tests covering warnings for 2026-07-28 and no warnings for older protocol versions. Closes modelcontextprotocol#390
atesgoral
force-pushed
the
issue-390-deprecations
branch
from
0c7a871 to
be41c3c
Compare
atesgoral
changed the title
atesgoral
changed the title
Contributor
Author
|
@koic Happy to push this through or were you thinking of doing the deprecation later? |
Member
|
I'd lean toward doing the deprecation later rather than merging the full behavior change now. This SEP introduces a behavioral switch tied to protocol versioning, and I think that design makes sense because it preserves compatibility with existing protocol versions. However, the 2026-07-28 specification hasn't actually been released yet, and it doesn't appear to have been added to Given that, I'd prefer to wait until the 2026-07-28 release is closer before enabling the deprecation behavior. In the meantime, it might be reasonable to land the advisory annotations on their own. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Deprecate MCP Roots, Sampling, and Logging only when protocol version
2026-07-28is negotiated or explicitly configured.Context
SEP-2577 deprecates Roots, Sampling, and Logging in the
2026-07-28protocol version.Closes #390
Changes
2026-07-28as an explicitly supported stable protocol version while keepingLATEST_STABLE_PROTOCOL_VERSIONat2025-11-25.Kernel.warnmessages only for2026-07-28.2026-07-28.@deprecatednotes and regression tests for both warning and no-warning behavior.Testing
GEM_HOME="$PWD/.gem-test" GEM_PATH="$PWD/.gem-test:/nix/store/jh918yiwd5cs4pjg005ac32m2q7ckw3l-ruby-4.0.5/lib/ruby/gems/4.0.0" bundle exec rake testGEM_HOME="$PWD/.gem-test" GEM_PATH="$PWD/.gem-test:/nix/store/jh918yiwd5cs4pjg005ac32m2q7ckw3l-ruby-4.0.5/lib/ruby/gems/4.0.0" bundle exec rake rubocopgit diff --check