fix(runtime): upload SenseVoice weights to selected backend - #3555
Merged
Conversation
Signed-off-by: LauraGPT <18321252+LauraGPT@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The official
runtime-llamacpp-v0.2.3Windows Vulkan executable matches the reporter's SHA-256. A symbol build from the same source maps the reported+0x2dfde3access violation toggml_vk_tensor_subbuffer, wheresrc1->bufferis null before any Vulkan submission.A graph audit found 2,386 source tensors with null backend buffers. SenseVoice loaded GGUF weights with
no_alloc=falseinto an ordinary host context, while graph intermediates were allocated from the selected Vulkan buffer type. CPU accepted those host pointers; Vulkan requires a registered host allocation or a non-null backend buffer.This change follows llama.cpp's model-loading pattern: metadata-only GGUF context, backend tensor context, weights buffer allocation, and explicit tensor upload.
Validation
python -m pytest runtime/llama.cpp/tests -q: 23 passed803b7fca803b7fcacompute status=0compute status=0compute status=0compute status=0Relates to #3479. This fixes the symbolized host-side null-buffer path, but the issue should remain open until the official Windows Vulkan artifact passes on the reporter's Radeon 780M and RX 9070 XT systems.