Add GitHub Actions CI testing numpy 1.x + 2.x and transformers 4.x + 5.x - #85
Open
DrLHS wants to merge 1 commit into
Open
Add GitHub Actions CI testing numpy 1.x + 2.x and transformers 4.x + 5.x#85DrLHS wants to merge 1 commit into
DrLHS wants to merge 1 commit into
Conversation
Three-cell matrix that exercises momentfm against: - the pyproject lower bounds (numpy 1.26.4, transformers 4.54.1, torch 2.0.1) - a mid-range combination (transformers <5) - the numpy 2.x + transformers 5.x frontier (numpy>=2.0, transformers>=5.0, torch>=2.4) The frontier cell is the load-bearing one for downstream users who have already migrated to numpy 2.x. Today the PyPI release v0.1.4 strictly pins numpy==1.25.2 and transformers==4.33.3 and silently breaks in numpy-2 environments. `main` already has the loose pins (PR moment-timeseries-foundation-model#81), but there is no automated signal that they actually work together end-to-end. This workflow provides that signal. Each cell installs the matrix-pinned versions explicitly, then installs momentfm from source, then runs the existing pytest suite. Green CI on the frontier cell is the prerequisite for cutting v0.1.5 to PyPI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a CI workflow that tests momentfm against three dependency combinations on every push:
The frontier cell is the load-bearing one for any downstream user who has already migrated to numpy 2.x. Today the PyPI release
v0.1.4strictly pinsnumpy==1.25.2andtransformers==4.33.3and so silently breaks in numpy-2 environments.mainalready has the loose pins (PR #81), but there's no automated signal that they actually work together end-to-end. This workflow provides that signal.Each cell installs the matrix-pinned versions explicitly, then installs momentfm from source, then runs the existing pytest suite (no existing tests are touched). Green CI on the frontier cell is the prerequisite for cutting
v0.1.5to PyPI — see #84.Files changed:
.github/workflows/ci.yml(new, 71 lines).