feat(theme): add boba theme (@Chouhan705)#7995
Conversation
monkeytypegeorge
added
frontend
Chouhan705
changed the title
|
here is a screenshot of the theme for reference |
| } | ||
| } | ||
|
|
||
| /* Tiny spacing tweaks to prevent clipping issues */ |
There was a problem hiding this comment.
should be obsolete when we remove the effect on the logoText
|
similar to hanok and tiramisu |
|
Thanks for the feedback! Makes total sense to keep the branding unified. I've removed the logo gradient overrides so it behaves cleanly now , and sorry for the delay I was on a vacation :) |
| A cozy, milk-tea inspired palette with dark tapioca contrast. :) | ||
| ========================================================================== */ | ||
|
|
||
| :root { |
| --caret-color: #c39b7d; | ||
| } | ||
|
|
||
| /* removed the logo changes |
github-actions
Bot
added
the
waiting for update
github-actions
Bot
removed
the
waiting for update
|
"My bad! Cleaned out all the comments and headers entirely to keep the file lightweight. Just pushed the update." |
| @@ -0,0 +1,74 @@ | |||
| :root { | |||
There was a problem hiding this comment.
the whole rule is not needed, remove :root{...}
| } | ||
| } | ||
|
|
||
| nav { |
There was a problem hiding this comment.
both rules for navand headershould not be needed
github-actions
Bot
added
the
waiting for update
|
Ah, got it! Didn't realize the TypeScript tokens auto-injected those into the root context. Removed the redundant :root block along with the layout padding rules entirely to keep it clean. Thanks! |
github-actions
Bot
removed
the
waiting for update
github-actions
Bot
added
the
waiting for review
|
Hey there! Just wanted to check in on this. I've stripped out the redundant :root block and the layout selectors as requested, so the file is down to just the essential navigation overrides now. Let me know if it's good to go! |
|
Yes, looks good |
|
Awesome, glad it looks good! Could you officially approve the PR or clear the changes requested state whenever you get a chance? GitHub is currently blocking the merge until the status updates. Thanks again for the review! |
3 participants
Added a new theme called Boba, inspired by warm brown-sugar milk tea and taro colors. The goal was to introduce a cozy, warm-toned aesthetic variant to the theme selection that maintains strong contrast ratios for active typing legibility.
I implemented the color palette configs, linked up the custom styles, and registered it within the application constants and validation schemas.
Checks
[ ] Adding quotes?
[ ] Adding a language?
[x] Adding a theme?
Make sure to follow the themes documentation
[x] Add theme to packages/schemas/src/themes.ts
[x] Add theme to frontend/src/ts/constants/themes.ts
[x] (optional) Add theme css file to frontend/static/themes
[ ] Add some screenshots of the theme, especially with different test settings (colorful, flip colors) to your pull request
[ ] Adding a layout?
[ ] Adding a font?
[x] Check if any open issues are related to this PR; if so, be sure to tag them below.
[x] Make sure the PR title follows the Conventional Commits standard.
[x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.