Conversation
QGarchery
commented
Jun 29, 2026
QGarchery
commented
Jun 29, 2026
| address onBehalf, | ||
| TokenPermit memory aTokenPermit, | ||
| uint256 deadline | ||
| ) external { |
Collaborator
Author
There was a problem hiding this comment.
Didn't add a prior repay step (which is an action that exists in bundler3), which would allow to repay and withdraw the collateral to deposit on a vault v2. It doesn't seem to make a lot of sense to add it:
- it would be most useful if we integrate a swap mechanism, but it's not planned atm
- it would enable to deposit a collateral into a vault v2, which doesn't seem like a big use case
QGarchery
changed the title
QGarchery
commented
Jun 30, 2026
MathisGD
reviewed
Jul 9, 2026
Collaborator
There was a problem hiding this comment.
worth a fork integration test?
QGarchery
commented
Jul 9, 2026
| require(asset == IAToken(aToken).UNDERLYING_ASSET_ADDRESS(), InconsistentTokens()); | ||
|
|
||
| TokenLib.pullToken(aToken, msg.sender, amount, aTokenPermit); | ||
| uint256 withdrawn = IAaveV3(aaveV3Pool).withdraw(asset, type(uint256).max, address(this)); |
Collaborator
Author
There was a problem hiding this comment.
Not doing slippage check for this withdraw, because withdrawing 1 aTokens give out about 1 underlying:
- token is rebalancing to account for interest
- bad debt can be realized, but it's under Umbrella system which only burns it own aToken (so no "price" repercussion to users)
MathisGD
reviewed
Jul 10, 2026
MathisGD
reviewed
Jul 10, 2026
MathisGD
reviewed
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
migration from aave v3 to vault v2
paused for now