Skip to content

Add global timeout for all operations within connection - #259

Open
decaz wants to merge 2 commits into
mosquito:masterfrom
decaz:operation-timeout
Open

Add global timeout for all operations within connection#259
decaz wants to merge 2 commits into
mosquito:masterfrom
decaz:operation-timeout

Conversation

@decaz

@decaz decaz commented Oct 3, 2019

Copy link
Copy Markdown
Collaborator

Currently every operation should be called with timeout parameter to catch timeout of operations. With operation_timeout parameter of connection it would be much easier.

@decaz decaz changed the title Add global timeout for all operations within connection [WIP] Add global timeout for all operations within connection Oct 3, 2019
@decaz

decaz commented Oct 3, 2019

Copy link
Copy Markdown
Collaborator Author

Default value of timeout parameters should be some special object (OPERATION_TIMEOUT for example) because None should mean no timeout at all. Will add it soon. Done.

Comment thread tests/test_amqp.py
@decaz decaz changed the title [WIP] Add global timeout for all operations within connection Add global timeout for all operations within connection Oct 4, 2019
@decaz
decaz force-pushed the operation-timeout branch from 74799ce to ec9c803 Compare October 4, 2019 11:19
@mosquito

Copy link
Copy Markdown
Owner

Please rebase

@decaz
decaz force-pushed the operation-timeout branch from ec9c803 to 7aa9991 Compare November 20, 2019 09:53
@decaz

decaz commented Nov 20, 2019

Copy link
Copy Markdown
Collaborator Author

@mosquito done.

@mosquito

Copy link
Copy Markdown
Owner

Sorry for long answer, but why you want to add a parameter to the methods and use asyncio.wait_for inside them instead of wrapping asyncio.wait_for externally?

@decaz

decaz commented Feb 14, 2020

Copy link
Copy Markdown
Collaborator Author

@mosquito because wait_for and timeout parameters are already inside library methods and you don't have to wrap them everywhere within your code.

@decaz
decaz force-pushed the operation-timeout branch from 7aa9991 to 19868d1 Compare February 14, 2020 17:18
@aviramha

aviramha commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

Update on this?

@mosquito

Copy link
Copy Markdown
Owner

please resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants