Prefer GTFS entrances for footpath generation#976
Prefer GTFS entrances for footpath generation#976DomeQdev wants to merge 2 commits intomotis-project:masterfrom
Conversation
|
There's no real value in routing to entrances if there's no support for Additionally, this seems to only deal with I'm also not sure if only routing to a closest entry based on distance is a good choice. Overall I would not like to tackle this problem this way as as long as we do not have a proper modeling of pathways.txt in nigiri. I would also recommend to discuss your approach before starting to work on something for several reasons:
As @traines-source mentioned, the preferred way is to fix the modeling in OSM. OSM is way more precise and enables seamless routing between first/last mile and transit and in/outdoor. |
|
I agree that for a user it's probably better to be routed to the entry if we compare it to the "dummy leg" case where there's no route found at all. However, I would distinguish here between
The code changed in this PR at the moment deals with the first case (and specifically only the transfer case, not first/last mile). So the route shown to the user will still not be the one leading to the entrance. The code you adapted in the your other PR (to ignore level information if the first try with exact levels didn't work) seems a way better place to do this as those are the routes actually shown to the user. Then maybe the better fallback order would be:
Currently, entrances are not extracted in nigiri. So anything you want to do with entrances will not work unless this check in nigiri is removed: |

This PR adds a
prefer_gtfs_entrancesconfig option. When enabled, MOTIS will use station entrances from GTFS (location_type=2) for generating pedestrian footpaths, falling back to OSM only if GTFS entrances are not available for a station.This improves intermodal routing accuracy in areas where GTFS entrance data is more reliable than OSM. To ensure good performance, the implementation routes from the single closest entrance to a neighboring station, avoiding a costly computation from all possible entrances.
Fixes #919