Fix URL autocomplete replacement#510
Merged
Merged
Conversation
gschier
marked this pull request as ready for review
July 15, 2026 15:08
Greptile SummaryThis PR fixes URL autocomplete replacement in HTTP and WebSocket request bars. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| apps/yaak-client/components/core/Editor/url/completion.ts | Adds shared URL options and custom replacement ranges for protocol and saved-URL completions. |
| apps/yaak-client/components/core/Editor/genericCompletion.ts | Allows generic completion options to provide a CodeMirror apply handler. |
| apps/yaak-client/components/core/Editor/url/completion.test.ts | Covers protocol suffix handling, protocol insertion, saved-URL replacement, and option composition. |
| apps/yaak-client/components/HttpRequestPane.tsx | Uses the shared URL completion configuration for HTTP requests. |
| apps/yaak-client/components/WebsocketRequestPane.tsx | Uses the shared URL completion configuration for WebSocket requests. |
Reviews (4): Last reviewed commit: "Reapply "Always include URL protocols"" | Re-trigger Greptile
greptile-apps
Bot
dismissed
their stale review
July 15, 2026 15:13
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
This reverts commit 81248aa.
greptile-apps
Bot
dismissed
their stale review
July 15, 2026 15:19
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
This reverts commit 706d158.
greptile-apps
Bot
dismissed
their stale review
July 15, 2026 15:28
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes URL autocomplete inserting a second protocol separator or appending a saved URL to the existing value.
http://orhttps://before an existing://https://yaak.app/feedback/posts/autocomplete-inserts-duplicate-protocol