HNT-2084: Switch image_gcs to GCP v2 and remove dual-write - #1371
Open
mmiermans wants to merge 2 commits into
Open
HNT-2084: Switch image_gcs to GCP v2 and remove dual-write#1371mmiermans wants to merge 2 commits into
mmiermans wants to merge 2 commits into
Conversation
Repoint [image_gcs] config from v1 project (moz-fx-merino-prod-1c2f) to v2 project (moz-fx-merino-prod-5de4), remove the now-redundant [image_gcs_v2] config sections, and clean up dual-write logic in Finance/Polygon and FlightAware. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
looks good to me so far. let me know when it's ready for review 👍🏾 |
mmiermans
marked this pull request as ready for review
April 10, 2026 15:46
Herraj
approved these changes
Apr 10, 2026
ncloudioj
approved these changes
Apr 10, 2026
ncloudioj
left a comment
ncloudioj
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks! Just a few more changes for stage.toml.
| # Set to `true` in production and `false` in staging or development. | ||
| gcs_enabled = false | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Could you update the following entries for stage.image_gcs and stage.curated_recommendations.gcs?
[stage.image_gcs]
# MERINO_IMAGE_GCS__GCS_PROJECT
gcs_project = "moz-fx-merino-nonprod-db57"
# MERINO_IMAGE_GCS__GCS_BUCKET
gcs_bucket = "merino-images-stage"
[stage.curated_recommendations.gcs]
# MERINO__CURATED_RECOMMENDATIONS__GCS__BUCKET_NAME
# GCS bucket that contains aggregate engagement and prior data
bucket_name = "merino-airflow-data-stage"
# MERINO__CURATED_RECOMMENDATIONS__GCS__GCP_PROJECT
# GCP project name where the GCS bucket lives.
gcp_project = "moz-fx-merino-nonprod-db57"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
JIRA: HNT-2084
Description
Repoint
[image_gcs]config from v1 project (moz-fx-merino-prod-1c2f/merino-images-prodpy) to v2 project (moz-fx-merino-prod-5de4/merino-images-prod). Remove the now-redundant[image_gcs_v2]config sections, validators, and dual-write logic in Finance/Polygon, FlightAware, and Suggest manager.This unblocks decommissioning the v1 GCP project. Without this change, the manifest provider, ADM icon processing, Top Picks, Finance, and FlightAware all read from the v1 bucket — and curated-recommendations is indirectly affected via publisher icons.
PR Review Checklist
Put an
xin the boxes that apply[DISCO-####], and has the same title (if applicable)[load test: (abort|skip|warn)]keywords are applied to the last commit message (if applicable)🤖 Generated with Claude Code