Bug 2053207 - Use glean-sym for places telemetry [ci full]#7468
Conversation
| # | ||
| # * Fenix for Android | ||
| # This file defines the metrics that are recorded by android for the places component. | ||
| # It's no longer used, but we still need to keep it around for probe-scraper reasons. |
There was a problem hiding this comment.
I believe this is true, is there a better way to deal with this? If not, it's not that bad and I believe the issue goes away when we move into moz-central?
| uniffi = { version = "0.31" } | ||
| glean-sym = { git = "https://github.com/mozilla/glean", tag = "v68.0.0", optional = true } | ||
| glean = { version = "68.0.1", optional = true } | ||
| glean-sym = { git = "https://github.com/mozilla/glean", tag = "v68.0.1", optional = true } |
There was a problem hiding this comment.
Would it be worth it to publish glean-sym so that we get all the dependencies from the same source?
| let timer_id = glean_metrics::places_manager::run_maintenance_prune_time.start(); | ||
| let res = | ||
| self.with_conn(|conn| storage::run_maintenance_prune(conn, db_size_limit, prune_limit)); | ||
| #[cfg(any(feature = "glean-sym", feature = "glean-fog"))] |
There was a problem hiding this comment.
Having to feature flag everything like this isn't great. One idea I had would is adding support for a rust-noop format to glean_parser. That would generate the same code as rust/rust-sym, but with the function bodies wouldn't do anything. @badboy what do you think about this? I could try my hand at implementing it if the glean team was busy with other things.
|
This seems to be working and I even did a quick check that the FOG stuff works on desktop. However, I'm not sure about a couple things and I left comments for them. |
Use glean-sym for real, rather than just for test metrics. Added support for Desktop/FOG. Removed the metrics meant to test glean-sym. Simplified `run_maintenance` now that we can record metrics in Rust. Updated chrono to `0.4.45` for compatibility with `glean`
bendk
force-pushed
the
bdk/push-xpvmlnrlprkk
branch
from
b7dcf9b to
6a9a5e6
Compare
|
The tests are failing because pip3 can't find the right glean_parser version. I'm not sure what's happening there, any ideas? |
1 participant
Use glean-sym for real, rather than just for test metrics. Added support for Desktop/FOG. Removed the metrics meant to test glean-sym.
Simplified
run_maintenancenow that we can record metrics in Rust.Updated chrono to
0.4.45for compatibility withgleanPull Request checklist
[ci full]to the PR title.