Add skill quality validator for skill metadata and workflow checks - #91
Open
SayanDey322 wants to merge 1 commit into
Open
Add skill quality validator for skill metadata and workflow checks#91SayanDey322 wants to merge 1 commit into
SayanDey322 wants to merge 1 commit into
Conversation
This was referenced Jun 26, 2026
mukul975
requested changes
Jun 26, 2026
mukul975
left a comment
Owner
There was a problem hiding this comment.
Thanks for this. A few blocking issues, and a direction note:
- Committed scratch output. This PR commits
tools/skill_quality_validator_output.txt,_output2.txt, and_output3.txt— generated tool logs that shouldn't land in the repo. Please remove all three. - Parallel validator overlap. This adds a standalone
tools/skill_quality_validator.pyalongside the existingtools/validate-skill.py. The repo should have one validator, not two. PR #87 (nested-name fix) is already merged intovalidate-skill.py, and #88 is extending that same file with tag-quality/workflow/prereq checks — which overlaps much of what this PR does. - Direction. Rather than a second validator, please fold any genuinely new checks here into the existing
validate-skill.py(coordinate with #88 to avoid duplication). If everything here is already covered by #87 + #88, this PR can be closed as subsumed.
(Note: #92, the exact duplicate of this PR, has been closed; this is the surviving one.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented a lightweight skill quality validator to improve consistency across SKILL.md files.
Changes
Testing
python tools/skill_quality_validator.py skills/
Issue: #86