Skip to content

use closed=True in some TypeDict cases#3800

Open
MarcoGorelli wants to merge 2 commits into
narwhals-dev:mainfrom
MarcoGorelli:closed-typeddict
Open

use closed=True in some TypeDict cases#3800
MarcoGorelli wants to merge 2 commits into
narwhals-dev:mainfrom
MarcoGorelli:closed-typeddict

Conversation

@MarcoGorelli

@MarcoGorelli MarcoGorelli commented Jul 17, 2026

Copy link
Copy Markdown
Member

closes #3661

this becomes a bit easier to review if you hide whitespace changes: https://github.com/narwhals-dev/narwhals/pull/3800/changes?w=1

i've unpinned mypy/pyrefly from pyproject.toml, as the version used in CI is taken from the lock file anyway, and like this dependabot updates will take care of those updates. note that we need a mypy version more recent than 2.1.0 for this PR to work

Description

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

AI assistance

  • No AI tools were used for this PR.
  • AI tools were used.

Checklist

  • Code follows style guide (ruff)

  • Tests added

  • Documented the changes

  • If this is your first PR to narwhals, attach a screenshot of pytest passing locally (not CI):

    PYTEST_ADDOPTS="--numprocesses=logical" \
    make run-ci DEPS="--extra pandas --extra dask --group core-tests --group sklearn --group plugins" \
    CMD="pytest tests --cov=src --cov=tests --runslow --constructors=pandas,pandas[nullable],pandas[pyarrow],pyarrow,polars[eager],polars[lazy],dask,duckdb,sqlframe"

@MarcoGorelli
MarcoGorelli marked this pull request as ready for review July 17, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use typed dicts with closed=True in from_native

1 participant