fix: bump @types/pg minimum version to ^8.11.3#203
Open
gn00295120 wants to merge 1 commit into
Open
Conversation
QueryConfigValues type is imported in src/pool.ts but was only added to @types/pg in version 8.11.3. The previous constraint ^8.8.0 allows resolution to versions that don't export this type, causing type errors for consumers. Fixes neondatabase#180
There was a problem hiding this comment.
Pull request overview
This PR updates the published dependency constraint for @types/pg to ensure downstream TypeScript consumers always receive a version that exports QueryConfigValues, matching the library’s current type usage (Fixes #180).
Changes:
- Bump
@types/pgminimum supported version from^8.8.0to^8.11.3inpackage.json.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
63
to
66
| "dependencies": { | ||
| "@types/node": "^22.15.30", | ||
| "@types/pg": "^8.8.0" | ||
| "@types/pg": "^8.11.3" | ||
| }, |
There was a problem hiding this comment.
package-lock.json is now out of sync with package.json: the lockfile still declares "@types/pg": "^8.8.0" (package-lock.json:14). This will typically cause npm ci to fail due to a dependency mismatch. Regenerate/update the lockfile so it reflects ^8.11.3 (and the resolved version) and commit the updated lockfile as part of this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QueryConfigValuesis imported insrc/pool.tsbut was only added to@types/pgin version8.11.3. The current dependency constraint^8.8.0allows npm to resolve to versions that don't export this type, causing type errors for downstream consumers.This bumps the minimum to
^8.11.3to match actual usage.Fixes #180