Supporting non contiguous domain on RegularTimeseries#40
Draft
AlexandreAndr wants to merge 31 commits intomainfrom
Draft
Supporting non contiguous domain on RegularTimeseries#40AlexandreAndr wants to merge 31 commits intomainfrom
AlexandreAndr wants to merge 31 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces tests to support non contiguous domains in RegularTimeSeries objects. Key changes include the addition of a new test function for non contiguous domains, adjustments in import ordering, and updates to the collection of imported symbols.
Comments suppressed due to low confidence (3)
tests/test_data.py:820
- [nitpick] The variable 'regular_timseries' appears to be misspelled. Consider renaming it to 'regular_timeseries' for clarity, and ensure that 'base_sampling_rate' and 'v' are defined before use.
regular_timseries = RegularTimeSeries(
tests/test_data.py:815
- The variable 'b' is used but not defined in this test. Consider replacing 'b' with 'a' if the intended object is the one instantiated above.
assert np.allclose(b.timestamps, np.arange(0, 10, 0.1))
tests/test_data.py:818
- The variables 'start' and 'end' are not defined in this context. Define these values or use the appropriate variables to represent the intended interval boundaries.
domain = Interval(start, end)
…Series and IrregularTimeSeries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description: Support for Non-Contiguous Domains on
RegularTimeSeriesandLazyRegularTimeSeriesOverview
This pull request introduces support for non-contiguous domains with
RegularTimeSeriesto handle disjoint intervals, improving slicing operations, domain calculations, and timestamp generation for complex datasets.Key Changes
Non-Contiguous Domain Support:
RegularTimeSeriesclass to handle disjoint intervals in the domain.slicemethod) to work seamlessly with non-contiguous domains, ensuring accurate extraction of data across multiple intervals.Expanded Test Suite:
Refinements to Mask Creation:
add_split_masktest on other objectIrregularTimeSeries(can be moved to another PR).Testing
Here is an example of a
RegularTimeSerieswith non contiguous domains: