fix(weather_status): load translations when injecting dashboard widget script#60289
Open
miaulalala wants to merge 1 commit into
Open
fix(weather_status): load translations when injecting dashboard widget script#60289miaulalala wants to merge 1 commit into
miaulalala wants to merge 1 commit into
Conversation
…t script
The BeforeTemplateRenderedListener injected the weather-status script into
the dashboard page but never loaded the app's translation strings, causing
all t('weather_status', ...) calls to fall back to raw English source strings.
Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
miaulalala
requested review from
ArtificialOwl,
CarlSchwan,
leftybournes and
provokateurin
and removed request for
a team
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
What about #60179 (comment)?
Maybe this fix is only needed for older stable branches?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BeforeTemplateRenderedListenerinjected theweather-statusscript into the dashboard page but never calledUtil::addTranslations('weather_status')t('weather_status', ...)calls in the weather widget fell back to raw English source strings, breaking localisation for all non-English usersUtil::addTranslations('weather_status')alongside the existingaddScriptcallNeeds backport to stable32.
Fixes #60179
Test plan
AI-Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com