Skip to content

fix(files_sharing): Fail on sharing file with create or delete permission before failing on increased permissions #61929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
provokateurin merged 1 commit into from
Jul 9, 2026
+25 −5
Merged

fix(files_sharing): Fail on sharing file with create or delete permission before failing on increased permissions #61929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apps/files_sharing/lib/Listener/RestrictInteractionListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,6 @@ public function handle(Event $event): void {
}

if ($event->action->filesSharingPermissions !== null) {
if (($event->action->filesSharingPermissions & ~$event->resource->getNodePermissions()) !== 0) {
$path = $userFolder->getRelativePath($event->resource->getNode()->getPath());
throw new InteractionRestrictedException('Cannot share node with more permissions than the node already has.', $this->l10n->t('You cannot share "%s" with more permission than you have yourself.', [$path]));
}

if ($event->resource->getNode() instanceof File) {
if (($event->action->filesSharingPermissions & Constants::PERMISSION_DELETE) === Constants::PERMISSION_DELETE) {
throw new InteractionRestrictedException('Cannot share file node with delete permission.', $this->l10n->t('File cannot be shared with delete permission.'));
Expand All @@ -83,6 +78,11 @@ public function handle(Event $event): void {
&& !$this->manager->shareApiLinkAllowPublicUpload()) {
throw new InteractionRestrictedException('Public upload is not allowed.', $this->l10n->t('Public upload is not allowed.'));
}

if (($event->action->filesSharingPermissions & ~$event->resource->getNodePermissions()) !== 0) {
$path = $userFolder->getRelativePath($event->resource->getNode()->getPath());
throw new InteractionRestrictedException('Cannot share node with more permissions than the node already has.', $this->l10n->t('You cannot share "%s" with more permission than you have yourself.', [$path]));
}
}
}
}
Expand Down
20 changes: 20 additions & 0 deletions apps/files_sharing/tests/Listener/RestrictInteractionListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,26 @@ public function testNodeResourceShareActionIncreasePermission(): void {
}
}

public function testNodeResourceShareActionIncreasePermissionFileDelete(): void {
$userFolder = Server::get(IRootFolder::class)->getUserFolder($this->user->getUID());

$node = $userFolder->newFile('foo.txt', 'bar');
$node->getStorage()->getCache()->update($node->getId(), ['permissions' => Constants::PERMISSION_READ | Constants::PERMISSION_SHARE]);

$event = new RestrictInteractionEvent($this->user->getUID(), $this->user, new NodeResource($node->getId(), $this->user->getUID(), $node), new ShareAction(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE | Constants::PERMISSION_DELETE), null);
$this->assertEquals('File cannot be shared with delete permission.', $event->isInteractionRestricted());
}

public function testNodeResourceShareActionIncreasePermissionFileCreate(): void {
$userFolder = Server::get(IRootFolder::class)->getUserFolder($this->user->getUID());

$node = $userFolder->newFile('foo.txt', 'bar');
$node->getStorage()->getCache()->update($node->getId(), ['permissions' => Constants::PERMISSION_READ | Constants::PERMISSION_SHARE]);

$event = new RestrictInteractionEvent($this->user->getUID(), $this->user, new NodeResource($node->getId(), $this->user->getUID(), $node), new ShareAction(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE | Constants::PERMISSION_CREATE), null);
$this->assertEquals('File cannot be shared with create permission.', $event->isInteractionRestricted());
}

public function testNodeResourceShareActionFileHasDeletePermission(): void {
$userFolder = Server::get(IRootFolder::class)->getUserFolder($this->user->getUID());

Expand Down
Loading