build(java): align toolchain and runtime to Java 25 (bytecode 17)#7310
Open
cristianrcv wants to merge 3 commits into
Open
build(java): align toolchain and runtime to Java 25 (bytecode 17)#7310cristianrcv wants to merge 3 commits into
cristianrcv wants to merge 3 commits into
Conversation
Adopt Java 25 as the build toolchain and runtime (Gradle toolchain, CI distribution and container base images) while keeping the language level and bytecode target at Java 17. Follows the proposed org-wide standard in the Java 25 ADR (seqeralabs/adr#48), which supersedes the 2024-12-03 Java 17/21 ADR. CI switches the JDK distribution from Temurin to Amazon Corretto per the ADR's preferred Linux distribution. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Cristian Ramon-Cortes <cristian.ramon-cortes@seqera.io>
✅ Deploy Preview for nextflow-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Align Gradle wrapper with 9.6.1 while keeping Java target at 17. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the build with the proposed org-wide Java 25 standard in seqeralabs/adr#48 (supersedes the 2024-12-03 Java 17/21 ADR): adopt Java 25 as the build toolchain and runtime, keep the language level and bytecode target at Java 17, and use Amazon Corretto as the CI JDK distribution (the ADR's preferred Linux distribution).
What changed
build.gradle):JavaLanguageVersion.of(21)→of(25).sourceCompatibility/targetCompatibilitystay at 17, so emitted bytecode remains Java 17..github/workflows/build.yml):distribution: 'temurin'→'corretto'(all setup-java steps). Thejava_versionmatrix already covers[17, 25]and is unchanged.docker/Dockerfile:amazoncorretto:21-al2023→25-al2023packing.gradle(distributed launcher image):amazoncorretto:17-alpine-jdk→25-alpine-jdktest-e2e/Dockerfile:amazoncorretto:17-al2023→25-al2023Why
Java 25 (latest LTS, Sep 2025) provides long-term security support and improved JVM warmup/performance. Keeping the bytecode target at 17 preserves interoperability with plugins and libraries still on Java 17.
Reviewer notes
amazoncorretto:25-alpine-jdkand25-al2023tags are acceptable/available before merging — these are a bigger runtime decision than the build toolchain and can be dropped from this PR if you'd rather move them separately.How to verify
[17, 25]matrix using Corretto.sourceCompatibility/targetCompatibility= 17).🤖 Generated with Claude Code