Add managed identity support for Azure Batch container registries#7316
Open
adamrtalbot wants to merge 3 commits into
Open
Add managed identity support for Azure Batch container registries#7316adamrtalbot wants to merge 3 commits into
adamrtalbot wants to merge 3 commits into
Conversation
Allow authenticating to a private container registry with a user-assigned managed identity via azure.registry.managedIdentityResourceId (or the AZURE_REGISTRY_MANAGED_RESOURCE_ID environment variable), as an alternative to userName/password. When set, the managed identity takes precedence. Generated by Claude Code Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
✅ Deploy Preview for nextflow-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
christopher-hakkaart
left a comment
christopher-hakkaart
left a comment
Collaborator
There was a problem hiding this comment.
Style suggestions.
Co-authored-by: Chris Hakkaart <chris.hakkaart@seqera.io> Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds support for authenticating to private container registries (e.g. Azure Container Registry) using a user-assigned managed identity, as an alternative to
userName/password.azure { registry { server = 'myregistry.azurecr.io' managedIdentityResourceId = '/subscriptions/<sub>/resourceGroups/<rg>/providers/Microsoft.ManagedIdentity/userAssignedIdentities/<name>' } }Details
azure.registry.managedIdentityResourceIdconfig option. Value is the full ARM resource ID of the user-assigned identity (what the Batch SDK'sBatchNodeIdentityReference.setResourceIdexpects), not a client-id GUID.AZURE_REGISTRY_MANAGED_RESOURCE_ID; config value wins over env.userName/password.ContainerRegistryReference.setIdentityReference(...).Limitation
The managed identity must already be attached to the pool nodes. Nextflow's data-plane pool creation (
BatchPoolCreateContent) has no identity setter, so this requires a pre-existing pool (or an identity attached out-of-band). Documented in the guide and reference.Tests
AzRegistryOptsTest: config/env/precedence for the resource id, fullisConfigured()matrix.AzBatchServiceTest:poolVmConfigcases for the username/password path and the managed-identity-wins path.Generated by Claude Code