updated local modules by KateSakharova · Pull Request #74 · nf-core/seqsubmit

KateSakharova · 2026-06-25T22:12:01Z

First attempt to fix tests for release:

Added missing conda env.yml
updated some tools and containers
moved some versions to topics (I know those are ugly) but it is easier for tests

github-actions · 2026-06-25T22:15:20Z

`nf-core pipelines lint` overall result: Passed ✅ ⚠️

Posted for pipeline commit 77f59c0

+| ✅ 253 tests passed       |+
#| ❔   8 tests were ignored |#
#| ❔   1 tests had warnings |#
!| ❗  14 tests had warnings |!

Details

❗ Test warnings:

readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
pipeline_todos - TODO string in README.md: Add bibliography of tools and data used in your pipeline
pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0
pipeline_todos - TODO string in CONTRIBUTING.md: Add any pipeline specific contribution guidelines here, such as coding styles, procedures, checklists etc.
pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here
pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed
pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
local_component_structure - rna_detection.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - fasta_validation.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - genome_evaluation.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure

❔ Tests ignored:

files_exist - File is ignored: conf/igenomes.config
files_exist - File is ignored: conf/igenomes_ignored.config
nextflow_config - Config variable ignored: params.input
files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
files_unchanged - File ignored due to lint config: assets/nf-core-seqsubmit_logo_light.png
files_unchanged - File ignored due to lint config: docs/images/nf-core-seqsubmit_logo_light.png
files_unchanged - File ignored due to lint config: docs/images/nf-core-seqsubmit_logo_dark.png
container_configs - container_configs

❔ Tests fixed:

rocrate_readme_sync - Mismatch fixed: RO-Crate description updated from README.md.

✅ Tests passed:

files_exist - File found: .gitattributes
files_exist - File found: .gitignore
files_exist - File found: .nf-core.yml
files_exist - File found: .prettierignore
files_exist - File found: .prettierrc.yml
files_exist - File found: CHANGELOG.md
files_exist - File found: CITATIONS.md
files_exist - File found: CODE_OF_CONDUCT.md
files_exist - File found: LICENSE or LICENSE.md or LICENCE or LICENCE.md
files_exist - File found: nextflow_schema.json
files_exist - File found: nextflow.config
files_exist - File found: README.md
files_exist - File found: .github/.dockstore.yml
files_exist - File found: .github/ISSUE_TEMPLATE/bug_report.yml
files_exist - File found: .github/ISSUE_TEMPLATE/config.yml
files_exist - File found: .github/ISSUE_TEMPLATE/feature_request.yml
files_exist - File found: .github/PULL_REQUEST_TEMPLATE.md
files_exist - File found: .github/workflows/branch.yml
files_exist - File found: .github/workflows/nf-test.yml
files_exist - File found: .github/actions/get-shards/action.yml
files_exist - File found: .github/actions/nf-test/action.yml
files_exist - File found: .github/workflows/linting_comment.yml
files_exist - File found: .github/workflows/linting.yml
files_exist - File found: assets/email_template.html
files_exist - File found: assets/email_template.txt
files_exist - File found: assets/sendmail_template.txt
files_exist - File found: assets/nf-core-seqsubmit_logo_light.png
files_exist - File found: conf/modules.config
files_exist - File found: conf/test.config
files_exist - File found: conf/test_full.config
files_exist - File found: docs/CONTRIBUTING.md
files_exist - File found: docs/images/nf-core-seqsubmit_logo_light.png
files_exist - File found: docs/images/nf-core-seqsubmit_logo_dark.png
files_exist - File found: docs/output.md
files_exist - File found: docs/README.md
files_exist - File found: docs/README.md
files_exist - File found: docs/usage.md
files_exist - File found: nf-test.config
files_exist - File found: tests/default.nf.test
files_exist - File found: main.nf
files_exist - File found: assets/multiqc_config.yml
files_exist - File found: conf/base.config
files_exist - File found: .github/workflows/awstest.yml
files_exist - File found: .github/workflows/awsfulltest.yml
files_exist - File found: modules.json
files_exist - File found: ro-crate-metadata.json
files_exist - File not found check: .github/ISSUE_TEMPLATE/bug_report.md
files_exist - File not found check: .github/ISSUE_TEMPLATE/feature_request.md
files_exist - File not found check: .github/workflows/push_dockerhub.yml
files_exist - File not found check: .markdownlint.yml
files_exist - File not found check: .nf-core.yaml
files_exist - File not found check: .yamllint.yml
files_exist - File not found check: bin/markdown_to_html.r
files_exist - File not found check: conf/aws.config
files_exist - File not found check: docs/images/nf-core-seqsubmit_logo.png
files_exist - File not found check: lib/Checks.groovy
files_exist - File not found check: lib/Completion.groovy
files_exist - File not found check: lib/NfcoreTemplate.groovy
files_exist - File not found check: lib/Utils.groovy
files_exist - File not found check: lib/Workflow.groovy
files_exist - File not found check: lib/WorkflowMain.groovy
files_exist - File not found check: lib/WorkflowSeqsubmit.groovy
files_exist - File not found check: parameters.settings.json
files_exist - File not found check: pipeline_template.yml
files_exist - File not found check: Singularity
files_exist - File not found check: lib/nfcore_external_java_deps.jar
files_exist - File not found check: .travis.yml
nextflow_config - Found nf-schema plugin
nextflow_config - Config variable found: manifest.name
nextflow_config - Config variable found: manifest.nextflowVersion
nextflow_config - Config variable found: manifest.description
nextflow_config - Config variable found: manifest.version
nextflow_config - Config variable found: manifest.homePage
nextflow_config - Config variable found: timeline.enabled
nextflow_config - Config variable found: trace.enabled
nextflow_config - Config variable found: report.enabled
nextflow_config - Config variable found: dag.enabled
nextflow_config - Config variable found: process.cpus
nextflow_config - Config variable found: process.memory
nextflow_config - Config variable found: process.time
nextflow_config - Config variable found: params.outdir
nextflow_config - Config variable found: manifest.mainScript
nextflow_config - Config variable found: timeline.file
nextflow_config - Config variable found: trace.file
nextflow_config - Config variable found: report.file
nextflow_config - Config variable found: dag.file
nextflow_config - Config variable (correctly) not found: params.nf_required_version
nextflow_config - Config variable (correctly) not found: params.container
nextflow_config - Config variable (correctly) not found: params.singleEnd
nextflow_config - Config variable (correctly) not found: params.igenomesIgnore
nextflow_config - Config variable (correctly) not found: params.name
nextflow_config - Config variable (correctly) not found: params.enable_conda
nextflow_config - Config variable (correctly) not found: params.max_cpus
nextflow_config - Config variable (correctly) not found: params.max_memory
nextflow_config - Config variable (correctly) not found: params.max_time
nextflow_config - Config variable (correctly) not found: params.validationFailUnrecognisedParams
nextflow_config - Config variable (correctly) not found: params.validationLenientMode
nextflow_config - Config variable (correctly) not found: params.validationSchemaIgnoreParams
nextflow_config - Config variable (correctly) not found: params.validationShowHiddenParams
nextflow_config - Config variable (correctly) not found: validation.failUnrecognisedParams
nextflow_config - Config variable (correctly) not found: validation.failUnrecognisedHeaders
nextflow_config - Config timeline.enabled had correct value: true
nextflow_config - Config report.enabled had correct value: true
nextflow_config - Config trace.enabled had correct value: true
nextflow_config - Config dag.enabled had correct value: true
nextflow_config - Config manifest.name began with nf-core/
nextflow_config - Config variable manifest.homePage began with https://github.com/nf-core/
nextflow_config - Config dag.file ended with .html
nextflow_config - Config variable manifest.nextflowVersion started with >= or !>=
nextflow_config - Config manifest.version ends in dev: 1.0.0dev
nextflow_config - Config params.custom_config_version is set to master
nextflow_config - Config params.custom_config_base is set to https://raw.githubusercontent.com/nf-core/configs/master
nextflow_config - Lines for loading custom profiles found
nextflow_config - nextflow.config contains configuration profile test
nextflow_config - Config default value correct: params.rrna_limit= 80.0
nextflow_config - Config default value correct: params.trna_limit= 18.0
nextflow_config - Config default value correct: params.cat_db_download_id= nr
nextflow_config - Config default value correct: params.checkm2_db_download_id= 14897628
nextflow_config - Config default value correct: params.custom_config_version= master
nextflow_config - Config default value correct: params.custom_config_base= https://raw.githubusercontent.com/nf-core/configs/master
nextflow_config - Config default value correct: params.publish_dir_mode= copy
nextflow_config - Config default value correct: params.max_multiqc_email_size= 25.MB
nextflow_config - Config default value correct: params.validate_params= true
nextflow_config - Config default value correct: params.pipelines_testdata_base_path= https://raw.githubusercontent.com/nf-core/test-datasets/
nextflow_config - Config default value correct: params.upload_tpa= false
nextflow_config - Config default value correct: params.test_upload= true
nextflow_config - Config default value correct: params.is_private= false
nextflow_config - Config default value correct: params.webincli_mode= submit
nf_test_content - 'tests/mag_no_coverage_paired_reads.nf.test' contains outdir parameter
nf_test_content - 'tests/mag_no_coverage_paired_reads.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/mag_no_coverage_paired_reads.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/mag_no_study_complete_metadata.nf.test' contains outdir parameter
nf_test_content - 'tests/mag_no_study_complete_metadata.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/mag_no_study_complete_metadata.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/assembly_no_study_complete_metadata.nf.test' contains outdir parameter
nf_test_content - 'tests/assembly_no_study_complete_metadata.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/assembly_no_study_complete_metadata.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/assembly_complete_metadata.nf.test' contains outdir parameter
nf_test_content - 'tests/assembly_complete_metadata.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/assembly_complete_metadata.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/mag_no_taxonomy.nf.test' contains outdir parameter
nf_test_content - 'tests/mag_no_taxonomy.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/mag_no_taxonomy.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/mag_one_contig.nf.test' contains outdir parameter
nf_test_content - 'tests/mag_one_contig.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/mag_one_contig.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/default.nf.test' contains outdir parameter
nf_test_content - 'tests/default.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/default.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/mag_no_rna_presence.nf.test' contains outdir parameter
nf_test_content - 'tests/mag_no_rna_presence.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/mag_no_rna_presence.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/mag_no_coverage_single_reads.nf.test' contains outdir parameter
nf_test_content - 'tests/mag_no_coverage_single_reads.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/mag_no_coverage_single_reads.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/mag_complete_metadata.nf.test' contains outdir parameter
nf_test_content - 'tests/mag_complete_metadata.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/mag_complete_metadata.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/assembly_no_coverage_paired_reads.nf.test' contains outdir parameter
nf_test_content - 'tests/assembly_no_coverage_paired_reads.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/assembly_no_coverage_paired_reads.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/assembly_one_contig.nf.test' contains outdir parameter
nf_test_content - 'tests/assembly_one_contig.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/assembly_one_contig.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/assembly_no_coverage_single_reads.nf.test' contains outdir parameter
nf_test_content - 'tests/assembly_no_coverage_single_reads.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/assembly_no_coverage_single_reads.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/reads_paired_end.nf.test' contains outdir parameter
nf_test_content - 'tests/reads_paired_end.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/reads_paired_end.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/nextflow.config' contains modules_testdata_base_path
nf_test_content - 'tests/nextflow.config' contains pipelines_testdata_base_path
nf_test_content - 'nf-test.config' sets a testsDir
nf_test_content - 'nf-test.config' sets a workDir
nf_test_content - 'nf-test.config' sets a configFile
files_unchanged - .gitattributes matches the template
files_unchanged - .prettierrc.yml matches the template
files_unchanged - CODE_OF_CONDUCT.md matches the template
files_unchanged - LICENSE matches the template
files_unchanged - .github/.dockstore.yml matches the template
files_unchanged - .github/ISSUE_TEMPLATE/bug_report.yml matches the template
files_unchanged - .github/ISSUE_TEMPLATE/config.yml matches the template
files_unchanged - .github/ISSUE_TEMPLATE/feature_request.yml matches the template
files_unchanged - .github/workflows/branch.yml matches the template
files_unchanged - .github/workflows/linting_comment.yml matches the template
files_unchanged - .github/workflows/linting.yml matches the template
files_unchanged - assets/email_template.html matches the template
files_unchanged - assets/email_template.txt matches the template
files_unchanged - assets/sendmail_template.txt matches the template
files_unchanged - docs/README.md matches the template
files_unchanged - .gitignore matches the template
files_unchanged - .prettierignore matches the template
actions_nf_test - '.github/workflows/nf-test.yml' is triggered on expected events
actions_nf_test - '.github/workflows/nf-test.yml' checks minimum NF version
actions_awstest - '.github/workflows/awstest.yml' is triggered correctly
actions_awsfulltest - .github/workflows/awsfulltest.yml is triggered correctly
actions_awsfulltest - .github/workflows/awsfulltest.yml does not use -profile test
readme - README Nextflow minimum version badge matched config. Badge: 25.10.4, Config: 25.10.4
readme - README nf-core template version badge found.
pipeline_if_empty_null - No ifEmpty(null) strings found
plugin_includes - No wrong validation plugin imports have been found
pipeline_name_conventions - Name adheres to nf-core convention
template_strings - Did not find any Jinja template strings (0 files)
schema_lint - Schema lint passed
schema_lint - Schema title + description lint passed
schema_lint - Input mimetype lint passed: 'text/csv'
schema_params - Schema matched params returned from nextflow config
system_exit - No System.exit calls found
actions_schema_validation - Workflow validation passed: nf-test.yml
actions_schema_validation - Workflow validation passed: template-version-comment.yml
actions_schema_validation - Workflow validation passed: clean-up.yml
actions_schema_validation - Workflow validation passed: branch.yml
actions_schema_validation - Workflow validation passed: release-announcements.yml
actions_schema_validation - Workflow validation passed: awsfulltest.yml
actions_schema_validation - Workflow validation passed: awstest.yml
actions_schema_validation - Workflow validation passed: linting.yml
actions_schema_validation - Workflow validation passed: fix_linting.yml
actions_schema_validation - Workflow validation passed: linting_comment.yml
actions_schema_validation - Workflow validation passed: download_pipeline.yml
merge_markers - No merge markers found in pipeline files
modules_json - Only installed modules found in modules.json
multiqc_config - assets/multiqc_config.yml found and not ignored.
multiqc_config - assets/multiqc_config.yml contains report_section_order
multiqc_config - assets/multiqc_config.yml contains export_plots
multiqc_config - assets/multiqc_config.yml contains report_comment
multiqc_config - assets/multiqc_config.yml follows the ordering scheme of the minimally required plugins.
multiqc_config - assets/multiqc_config.yml contains a matching 'report_comment'.
multiqc_config - assets/multiqc_config.yml contains 'export_plots: true'.
modules_structure - modules directory structure is correct 'modules/nf-core/TOOL/SUBTOOL'
local_component_structure - local modules directory structure is correct 'modules/local/TOOL/SUBTOOL'
base_config - conf/base.config found and not ignored.
modules_config - conf/modules.config found and not ignored.
modules_config - FALINT found in conf/modules.config and Nextflow scripts.
modules_config - CATPACK_ADDNAMES_BINS found in conf/modules.config and Nextflow scripts.
modules_config - CATPACK_BINS found in conf/modules.config and Nextflow scripts.
modules_config - CATPACK_PREPARE found in conf/modules.config and Nextflow scripts.
modules_config - RENAME_FASTA_FOR_CATPACK found in conf/modules.config and Nextflow scripts.
modules_config - BARRNAP found in conf/modules.config and Nextflow scripts.
modules_config - TRNASCANSE found in conf/modules.config and Nextflow scripts.
modules_config - COUNT_RNA found in conf/modules.config and Nextflow scripts.
modules_config - CHECKM2_PREDICT found in conf/modules.config and Nextflow scripts.
modules_config - CHECKM2_DATABASEDOWNLOAD found in conf/modules.config and Nextflow scripts.
modules_config - COVERM_GENOME found in conf/modules.config and Nextflow scripts.
modules_config - COVERM_CONTIG found in conf/modules.config and Nextflow scripts.
modules_config - CREATE_ASSEMBLY_METADATA_CSV found in conf/modules.config and Nextflow scripts.
modules_config - CONCAT_METADATA found in conf/modules.config and Nextflow scripts.
modules_config - GENOME_UPLOAD found in conf/modules.config and Nextflow scripts.
modules_config - ENA_WEBIN_CLI_WRAPPER found in conf/modules.config and Nextflow scripts.
modules_config - REGISTERSTUDY found in conf/modules.config and Nextflow scripts.
modules_config - MULTIQC found in conf/modules.config and Nextflow scripts.
nfcore_yml - Repository type in .nf-core.yml is valid: pipeline
nfcore_yml - nf-core version in .nf-core.yml is set to the latest version: 4.0.2
rocrate_readme_sync - RO-Crate description matches the README.md.

Run details

nf-core/tools version 4.0.2
Run at 2026-06-25 23:18:48

ochkalova

Great job, Kate!

ochkalova · 2026-06-26T10:56:16Z

-  - "bioconda::mgnify-pipelines-toolkit"
+  - "bioconda::mgnify-pipelines-toolkit=1.5.1"
  - "conda-forge::openjdk"
+  - "bioconda::ena-webin-cli=9.0.3"


Have you tested it with conda? I wonder if it works 🤔

ochkalova · 2026-06-26T10:59:04Z

-    container "community.wave.seqera.io/library/pip_assembly-uploader:2a65298c0161c561"
+    conda "${moduleDir}/environment.yml"
+    container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
+        'https://depot.galaxyproject.org/singularity/assembly_uploader:1.3.5--pyhdfd78af_1':


Have you checked if this one really exists? 😆

ochkalova · 2026-06-26T11:01:34Z

@@ -1,4 +1,9 @@
 #!/usr/bin/env python3
+
+## Originally written by Tim Rozday and released under the MIT license.


After hours I spent on refactoring of this script, I want some fame as well 😃

Suggested change

## Originally written by Tim Rozday and released under the MIT license.

## Originally written by Tim Rozday, modified by Sofiia Ochkalova and released under the MIT license.

KateSakharova added 2 commits June 25, 2026 23:11

updated local modules

10907de

lint

9304176

KateSakharova mentioned this pull request Jun 25, 2026

add data for assembly nf-core/test-datasets#2120

Open

add versions

4e5b2ce

KateSakharova requested a review from ochkalova June 25, 2026 22:53

fixes for release

77f59c0

KateSakharova changed the base branch from dev to 1.0.0 June 25, 2026 23:21

ochkalova approved these changes Jun 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

updated local modules#74

updated local modules#74
KateSakharova wants to merge 4 commits into
1.0.0from
fix/conda-tests

KateSakharova commented Jun 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 25, 2026 •

edited

Loading

❗ Test warnings:

❔ Tests ignored:

❔ Tests fixed:

✅ Tests passed:

Run details

Uh oh!

ochkalova left a comment

Uh oh!

ochkalova Jun 26, 2026

Uh oh!

ochkalova Jun 26, 2026

Uh oh!

ochkalova Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -1,4 +1,9 @@
		#!/usr/bin/env python3

		## Originally written by Tim Rozday and released under the MIT license.

	## Originally written by Tim Rozday and released under the MIT license.
	## Originally written by Tim Rozday, modified by Sofiia Ochkalova and released under the MIT license.

Uh oh!

Conversation

KateSakharova commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

nf-core pipelines lint overall result: Passed ✅ ⚠️

❗ Test warnings:

❔ Tests ignored:

❔ Tests fixed:

✅ Tests passed:

Run details

Uh oh!

ochkalova left a comment

Choose a reason for hiding this comment

Uh oh!

ochkalova Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

ochkalova Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

ochkalova Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KateSakharova commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

`nf-core pipelines lint` overall result: Passed ✅ ⚠️