Fix responsive table when firstCellIsHeader is set#1174
Merged
colinrotherham merged 2 commits intomainfrom Apr 7, 2025
Merged
Conversation
colinrotherham
changed the title
firstCellIsHeader is setfirstCellIsHeader is set
Contributor
|
Nice, thanks for looking at this one. I don't think when in stacked layout that the bolded |
colinrotherham
force-pushed
the
table-classes
branch
from
23551c6 to
8d75b38
Compare
colinrotherham
force-pushed
the
table-responsive
branch
from
3a0e2e7 to
3d4dd40
Compare
colinrotherham
force-pushed
the
table-responsive
branch
3 times, most recently
from
2fdaa06 to
6cc8140
Compare
colinrotherham
force-pushed
the
table-responsive
branch
2 times, most recently
from
b2515b9 to
082373c
Compare
colinrotherham
force-pushed
the
table-responsive
branch
from
082373c to
71664bd
Compare
Contributor
Author
|
Do you mind reviewing this again please @anandamaryon1?
I've removed the |
anandamaryon1
approved these changes
Apr 7, 2025
Contributor
anandamaryon1
left a comment
anandamaryon1
left a comment
There was a problem hiding this comment.
Looks good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the Responsive table to restore
scope="row"whenfirstCellIsHeaderis enabledIt was split out from #1172 as part of #1171 and fixes #985
Checklist