Skip to content

move-workspace-to-monitor: Fetch previous workspace before moving#1944

Open
mattco98 wants to merge 1 commit intonikitabobko:mainfrom
mattco98:fetch-previous-workspace-before-moving
Open

move-workspace-to-monitor: Fetch previous workspace before moving#1944
mattco98 wants to merge 1 commit intonikitabobko:mainfrom
mattco98:fetch-previous-workspace-before-moving

Conversation

@mattco98
Copy link
Copy Markdown

@mattco98 mattco98 commented Feb 11, 2026

Otherwise the previous workspace will be the workspace that just moved, causing the "is not visible check" in getStubWorkspace to fail. As a result, the moving workspace is always replaced by the first non-empty workspace on that monitor, which is not intuitive.

PR checklist

  • Explain your changes in the relevant commit messages rather than in the PR description. The PR description must not contain more information than the commit messages (except for images and other media).
  • Each commit must explain what/why/how and motivation in its description. https://cbea.ms/git-commit/
  • Don't forget to link the appropriate issues/discussions in commit messages (if applicable).
  • Each commit must be an atomic change (a PR may contain several commits). Don't introduce new functional changes together with refactorings in the same commit.
  • ./run-tests.sh exits with non-zero exit code.
  • Avoid merge commits, always rebase and force push.

@mattco98 mattco98 force-pushed the fetch-previous-workspace-before-moving branch from 538d72f to ed7cf0f Compare February 11, 2026 05:58
@mattco98 mattco98 marked this pull request as draft February 11, 2026 16:55
Davincible added a commit to Davincible/AeroSpace that referenced this pull request Feb 11, 2026
@mattco98 mattco98 force-pushed the fetch-previous-workspace-before-moving branch from ed7cf0f to c5f11cd Compare February 12, 2026 02:33
@mattco98 mattco98 marked this pull request as ready for review February 12, 2026 02:34
Otherwise the previous workspace will be the workspace that just moved,
causing the "is not visible check" in `getStubWorkspace` to fail. As a
result, the moving workspace is always replaced by the first non-empty
workspace on that monitor, which is not intuitive.
@mattco98 mattco98 force-pushed the fetch-previous-workspace-before-moving branch from c5f11cd to 2a6e917 Compare February 21, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant