Conversation
|
@nikitabobko I realize my PR description is pretty verbose compared to the actual commit message for the change. I'm happy to force push/change the commit message to be more descriptive, and/or amend the PR body, too. |
@jperras Please do. I want to depend on GitHub as less as possible. All the information should be pushed directly into the git history (or code comments when appropriate) as much as possible |
a1c9a67 to
8b5a7bc
Compare
|
@nikitabobko added comments to the existing dumps, added an additional dump for a normal emacs window with no popups, and amended the commit message to be more informative. Everything squashed and force-pushed to this PR branch. |
Emacs has a concept of "child frames", which are effectively transient UI elements. These should not be managed by Aerospace. These child frames are now detected by checking for an AXSubrole of AXFloatingWindow, and AXMain with value 0 for the emacs bundle ID. Closes nikitabobko#776
8b5a7bc to
9d4be4b
Compare
Emacs has a concept of "child frames", which are effectively transient UI elements. These should not be managed by Aerospace.
These child frames are now detected by checking for an AXSubrole of AXFloatingWindow, and AXMain with value 0 for the emacs bundle ID.
This fixes the focus jumping issue when using Emacs completion/info popups (via common packages such as corfu, posframes, etc.) with AeroSpace.
Closes #776
Closes #1220
Refs. #1914
PR checklist
./run-tests.shexits with non-zero exit code.