chore: guard client[kUrl] in closeClientIfUnused loop#5532
Open
vctqs1 wants to merge 2 commits into
Open
Conversation
mcollina
requested changes
Jul 9, 2026
mcollina
left a comment
Member
There was a problem hiding this comment.
Thanks for opening a PR! Can you please add a unit test?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5532 +/- ##
==========================================
- Coverage 93.44% 93.44% -0.01%
==========================================
Files 110 110
Lines 37329 37329
==========================================
- Hits 34883 34881 -2
- Misses 2446 2448 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
When a custom factory (e.g
ProxyAgent) is used withAgentthe dispatcher registered inkClientsmay not havekUrlset.ProxyAgentextendsDispatcherBasedirectly and never assignsthis[kUrl]soclient[kUrl]isundefinedfor every proxied origin keyError.prepareStackTraceto surface the stack trace here . it was being suppressed because the frames originate fromnode:internal.Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status