Skip to content

Remove useless tests and pkg_resources#11

Merged
ultrabug merged 5 commits into
numberly:masterfrom
nledez:master
May 29, 2026
Merged

Remove useless tests and pkg_resources#11
ultrabug merged 5 commits into
numberly:masterfrom
nledez:master

Conversation

@nledez
Copy link
Copy Markdown
Contributor

@nledez nledez commented Feb 10, 2026 •
edited
Loading

Summary

  • Add pyproject.toml with setuptools and packaging as build-system requirements
  • Bump version from 0.2 to 0.3
  • Remove useless tests and pkg_resources

Motivation

pkg_resources (from setuptools) is deprecated and no longer guaranteed to be available in modern Python environments, causing ModuleNotFoundError on install. This PR migrates
to the standard library importlib.metadata and the standalone packaging library, which are the recommended replacements.

@nledez nledez mentioned this pull request Feb 10, 2026
Closed
@nledez nledez changed the title Migrate from deprecated pkg_resources to modern alternatives Remove useless tests and pkg_resources Feb 14, 2026
@ultrabug
Copy link
Copy Markdown
Member

ultrabug commented Mar 3, 2026

Thanks @nledez

I think we thus should update the setup.py classifiers to show that we now support 3.10 to 3.14?

@nledez
test: add unit tests with 100% code coverage and CI pipeline
b35140a 
  Add comprehensive test suite for Webhook, Attachment, and module exports
  with mocked HTTP interactions. Add GitHub Actions CI workflow running
  tests with coverage across Python 3.5 to 3.14. Document test commands
  in README.
@nledez
Copy link
Copy Markdown
Contributor Author

nledez commented Mar 11, 2026

Hi @ultrabug, absolutely. To do this, I added tests with 100% code coverage.
However, the CI only passes for Python versions 3.8 to 3.14.
I'm waiting for the first two versions to run, and I plan to remove 3.5 to 3.8 (which have been end of life since at least 2024 anyway).
What do you think?
Should I complete my PR to finish the cleanup?

@nledez
ci: add local test script and update Python version support to 3.8-3.14
ccfcdb6 
Add run_tests.sh using uv to run tests across Python 3.8 to 3.14.
Drop Python 3.5-3.7 from CI matrix and add 3.10-3.14 to setup.py
classifiers.
@nledez
Copy link
Copy Markdown
Contributor Author

nledez commented Mar 12, 2026

All tests are OK with last commit:
https://github.com/nledez/matterhook/actions/runs/22993132771

@ultrabug
Copy link
Copy Markdown
Member

ultrabug commented May 29, 2026

Thanks @nledez and super sorry for my latency

Should I complete my PR to finish the cleanup?

In a separate one please drop up to 3.9 included yes

@ultrabug ultrabug merged commit 94241c8 into numberly:master May 29, 2026
7 checks passed
@ultrabug
Copy link
Copy Markdown
Member

ultrabug commented May 29, 2026

I felt bad asking more from you after your patient wait, so I created #12 , will merge and release 0.3

@ultrabug
Copy link
Copy Markdown
Member

ultrabug commented May 29, 2026

All done, version 0.3 is released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nledez @ultrabug