fix(examples): guard against empty choices and message=None in LLM calls - #299
Open
qizwiz wants to merge 1 commit into
Open
fix(examples): guard against empty choices and message=None in LLM calls#299qizwiz wants to merge 1 commit into
qizwiz wants to merge 1 commit into
Conversation
client.chat.completions.create() can return choices=[] on content-policy rejections or provider errors, and choices[0].message=None on filtered responses (e.g. Gemini PROHIBITED_CONTENT via OpenAI-compatible endpoint). Both crash with IndexError/AttributeError. Guards added at all three access sites across reason1 and reason2 example scripts.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens three example scripts against OpenAI-compatible chat completion responses that return either an empty choices list or a None message, preventing IndexError/AttributeError crashes when accessing choices[0].message.content.
Changes:
- Add a guard for
not response.choicesbefore indexingchoices[0]. - Add a guard for
choices[0].message is Nonebefore readingmessage.content. - Raise a clear
ValueErrorwhen the response is empty/filtered.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/getting_started/nebius/reason2/src/cosmos_reason2_tests.py | Adds response-shape validation before printing/returning the LLM result in the Reason2 test runner. |
| scripts/examples/reason1/av_video_caption_vqa/model_openai.py | Adds response-shape validation before returning generated text from the OpenAI wrapper. |
| scripts/examples/reason1/temporal_localization/process_video_openai_api.py | Adds response-shape validation before returning caption/localization output from video processing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add explicit guards at three LLM call sites in example scripts before accessing
response.choices[0].message.content.Why
client.chat.completions.create()can return two empty-response shapes:choices = []— on content-policy rejections, rate-limit errors, or provider failureschoices[0].message = None— e.g. Gemini 2.5 Flash (via OpenAI-compatible endpoint) returns HTTP 200 withfinish_reason: PROHIBITED_CONTENTandmessage=NoneBoth crash with
IndexErrororAttributeError.Files changed
docs/getting_started/nebius/reason2/src/cosmos_reason2_tests.pyresponse.choices[0].message.contentscripts/examples/reason1/av_video_caption_vqa/model_openai.pyresponse.choices[0].message.contentscripts/examples/reason1/temporal_localization/process_video_openai_api.pyresp.choices[0].message.contentCorpus context
Detected by
pact(llm_response_unguardedmode), a Z3-verified static analyzer for LLM crash vectors. This pattern was found across 13.8k violations in 800+ repos.