perf(h1): reduce idle validation latency#22
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces HTTP/1 keep-alive reuse validation latency by scheduling the “idle socket validation” step with setImmediate instead of setTimeout(0), avoiding Node’s timer floor while still preserving the extra event-loop turn that can surface unsolicited bytes/FIN/RST before binding the next request.
Changes:
- Switch reused-idle-socket validation scheduling from
setTimeout(..., 0)tosetImmediate(...). - Switch cancellation from
clearTimeout(...)toclearImmediate(...). - Keep the existing
.unref?.()behavior on the scheduled handle.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setImmediateinstead ofsetTimeout(0)clearImmediateAdapted from nodejs/undici#5499 / issue #5493.
Performance
Five paired sequential keep-alive runs (
1,000measured requests/run):Validation
npm run lint -- --quietgit diff --check