Expose LG nature fan speed as auto - #956
Open
togume wants to merge 1 commit into
Open
Conversation
Author
|
@ollo69 hi hi! WDYT about this change? I've been testing it with a direct patch for over a month and it's been great to have "auto" cooling mode exposed to Apple Home. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose LG AC
NATUREfan speed as Home Assistantautoinstead ofdiffuse.Why
Automatic fan speed is unavailable on Apple Home. Some LG mini split models report their automatic fan behavior as
NATURE, which currently becomesdiffusein Home Assistant. Since this is the device-managed fan mode, exposing it as standardFAN_AUTOlets Home Assistant and HomeKit Bridge represent it as automatic fan control.When setting
fan_mode: auto, this keeps the existing LGAUTOfallback, but prefersNATUREwhen the device supports it.Tests
pytest tests/test_climate.pypytestblack --line-length 88 --diff --check custom_components/smartthinq_sensors/climate.py tests/test_climate.pyisort --diff --check custom_components/smartthinq_sensors/climate.py tests/test_climate.pyflake8 --extend-ignore=E704 custom_components/smartthinq_sensors/climate.py tests/test_climate.py