Fix style and low-severity findings from contract review#179
Merged
joshuahannan merged 2 commits intomainfrom Mar 24, 2026
Merged
Fix style and low-severity findings from contract review#179joshuahannan merged 2 commits intomainfrom
joshuahannan merged 2 commits intomainfrom
Conversation
- Fix #7: Replace nil-check + force-unwrap with if-let in Manager.borrowAccount, Manager.borrowAccountPublic, ChildAccount.getControllerIDForType, OwnedAccount.getControllerIDForType - Fix #8: Collapse double borrow of filter capability in publishToParent event - Fix #10: Add missing `view` to getAllPrivate in CapabilityDelegator interface and implementation - Fix #12: Correct copy-paste errors in AllowlistFilter doc comments ("denied types" -> "allowed types") - Fix #13: Remove duplicate comment line on ManagerPublic interface - Fix #14: Fix typo "itelf" -> "itself" - Fix #15: Remove spurious "AccountCapabilityController" fragment from CapabilityDelegator doc comment - Fix #16: Remove unresolved TODO from seal(); tracked in issue #178 - Fix #17: Decompose complex filter check in ChildAccount.getCapability into named variables with explanatory comments - Add CLAUDE.md and AGENTS.md (symlink) for Claude Code guidance - Add REPORT.md to .gitignore Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jribbink
approved these changes
Mar 24, 2026
Kay-Zee
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses style and low-severity findings identified during a comprehensive Cadence contract review. All 68 tests pass.
if letinManager.borrowAccount,Manager.borrowAccountPublic,ChildAccount.getControllerIDForType,OwnedAccount.getControllerIDForTypefiltercapability inpublishToParentevent emissionviewmodifier togetAllPrivateinCapabilityDelegatorinterface and implementation (consistent withgetAllPublic)AllowlistFilterdoc comments — "denied types" corrected to "allowed types"ManagerPublicinterfaceCapabilityDelegatordoc commentseal(); design concern tracked in issue seal() always revokes all keys — need a giveOwnership path that preserves keys #178ChildAccount.getCapabilityinto named variables with explanatory commentsCLAUDE.mdandAGENTS.md(symlink) for Claude Code guidanceREPORT.mdto.gitignoreRelated
🤖 Generated with Claude Code