docs: remove outdated State Resync Event section#1970
Open
kunalworldwide wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
dosubot
Bot
added
the
size:S
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe sync concepts documentation removes the outdated State Resync Events section and its related illustrations. ChangesSync documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Removes the State Resync Events section from syncs.md as it describes behavior that flagd does not actually support. Issue open-feature#1797 clarified that flagd does not handle cases where the same flag key is defined across multiple sources. The removed section incorrectly implied that a resync event would restore a flag definition from a lower-priority source when a higher-priority source deleted its version of the flag. Closes open-feature#1809 Signed-off-by: Kunal Das <kunalworldwide@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the "State Resync Events" section from as it describes behavior that flagd does not actually support.
Context
Issue #1797 clarified that flagd does not handle cases where the same flag key is defined across multiple sources. The removed section incorrectly implied that when a higher-priority source deletes its version of a flag, a resync event would restore the flag definition from a lower-priority source. This is not accurate behavior.
The section being removed included:
This is a minimal documentation-only fix with no code changes.
Closes #1809