fix(dq-dashboard): add Certification filter dropdown to Data Quality dashboard by manerow · Pull Request #28085 · open-metadata/OpenMetadata

manerow · 2026-05-13T10:40:31Z

Fixes open-metadata/openmetadata-collate#4080

What was wrong

Two places on the Data Observability dashboard silently lost certified assets:

The global dashboard's Tag filter listed certifications (Gold/Silver/Bronze), but selecting one returned zero coverage — the dashboard was querying the wrong field.
The Data Observability tab on a Certification tag's detail page (e.g. /tag/Certification.Gold) reported zero coverage for the same reason — the page told the dashboard to filter by tags, but certification doesn't live in the tags array.

What this PR changes

Adds a dedicated Certification dropdown to the dashboard filter row, sitting next to Tier. It loads Bronze/Silver/Gold from the Certification classification.
Stops listing Certification tags inside the generic Tag dropdown — they live in their own filter now, no double-counting.
Fixes the Tag detail page: when you visit a Certification tag, the embedded dashboard receives the certification through the correct filter key, so charts actually populate. The Certification filter is hidden on that page since it's already implied by the URL.
Adds a Playwright spec to pin the new behavior end-to-end.

Depends on

fix(dq-dashboard): denormalize certification onto testCase index + filter plumbing #28084 — the backend denormalization + filter type. Without it merged first, the Certification dropdown has nothing to query against on the test-case side.

Scope

Targets main and 1.13 only — on 1.12.x the dashboard component lives in the Collate repo (separate PR: open-metadata/openmetadata-collate#4079).
The Tag detail page's "Data Observability" tab is a 1.13+ feature, so no equivalent fix is needed for 1.12.x — the broken scenario simply doesn't exist there.

Test plan

Validated against a temp branch combining #28084 + this PR, deployed locally:

Playwright yarn playwright:run playwright/e2e/Features/DataQuality/CertificationFilter.spec.ts — 4/4 passing in ~9s.
Certification dropdown appears between Tier and Tag in the filter row.
Picking a Certification narrows both the table-index and testCase-index dashboard calls correctly (via certification.tagLabel.tagFQN).
Certification tags no longer appear in the generic Tag dropdown.
A Certification tag's detail page → Data Observability tab → embedded dashboard correctly reflects certified assets.
No regression on existing Tier / Tag / Glossary / Owner filters.

Follow-ups

Collate-side equivalent PR for 1.12.x: open-metadata/openmetadata-collate#4079.
A separate latent routing bug for Tier on testCase-driven widgets was discovered during this work. Not in scope here; tracked in open-metadata/openmetadata-collate#4086 with fix branch fix/dq-tier-routing.

shah-harshit · 2026-05-18T06:35:48Z

+  await afterAction();
+});
+
+function captureReports(


Let's move the util function to a separate file.

Moved to utils/dataQuality.ts as captureReports.

shah-harshit · 2026-05-18T06:36:57Z

+  await afterAction();
+});
+
+test.afterAll('cleanup', async ({ browser }) => {


We are not using afterAll unless it is required, since it takes up extra time to complete tests.

shah-harshit · 2026-05-18T06:38:21Z

+  storageState: 'playwright/.auth/admin.json',
+});
+
+const certTable = new TableClass();


Let's define the variables here and initlaize them in beforeAll.

Suggested change

const certTable = new TableClass();

let certTable:TableClass;

let cert: TagClass;

Done, switched both to let.

shah-harshit · 2026-05-18T06:39:12Z

+const cert = new TagClass({ classification: 'Certification' });
+
+test.beforeAll('setup', async ({ browser }) => {
+  const { apiContext, afterAction } = await createNewPage(browser);


We can add initializzation here.

Suggested change

const { apiContext, afterAction } = await createNewPage(browser);

certTable = new TableClass();

cert = new TagClass({ classification: 'Certification' });

const { apiContext, afterAction } = await createNewPage(browser);

Done, init moved into beforeAll.

The base branch was changed.

…rom Tag dropdown

…ated DQ filter keys

…ions list

gitar-bot · 2026-05-18T07:21:44Z

Code Review ✅ Approved 2 resolved / 2 findings

Adds a dedicated Certification filter dropdown to the Data Quality dashboard and routes tag pages through correct keys, resolving the search narrowing issue. No open issues found.

✅ 2 resolved

✅ Bug: handleCertificationSearch progressively narrows options

📄 openmetadata-ui/src/main/resources/ui/src/components/DataQuality/DataQualityDashboard/DataQualityDashboard.component.tsx:438-452
The handleCertificationSearch function filters prev.options (the already-filtered state) instead of filtering from the full original list. If a user types "Go" (filtering down to Gold), then changes to "B" (expecting Bronze), the filter runs against the already-narrowed array that only contains Gold — Bronze will never appear unless the user clears the input entirely.

This is the same pattern used by handleTierSearch, so it's a pre-existing issue copied forward. However, since the Certification dropdown has only 3 tags (Bronze, Silver, Gold), the practical impact is low — the user would need to edit mid-search to trigger it. Still worth fixing for correctness.

✅ Bug: Missing afterAll cleanup leaks test entities in CI

📄 openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/DataQuality/CertificationFilter.spec.ts:30-44
The previous commit had an afterAll block that deleted certTable and cert after the test suite completed. This delta removes it entirely without replacing it with an alternative cleanup mechanism (e.g., try…finally). Since neither TableClass nor TagClass has auto-cleanup, the Certification tag and table created in beforeAll will accumulate in the test environment on every run, potentially causing flaky tests or quota issues in CI.

Options

Display: compact → Showing less information.

Comment with these commands to change:

`Compact`
`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Gitar}

sonarqubecloud · 2026-05-18T07:53:40Z

Quality Gate passed for 'open-metadata-ui'

Issues
1352 New issues
0 Accepted issues

Measures
17 Security Hotspots
0.0% Coverage on New Code
4.0% Duplication on New Code

See analysis details on SonarQube Cloud

manerow requested a review from a team as a code owner May 13, 2026 10:40

github-actions Bot added backend safe to test Add this label to run secure Github workflows on PRs labels May 13, 2026

manerow added UI UI specific issues and removed backend labels May 13, 2026

manerow self-assigned this May 13, 2026

manerow had a problem deploying to test May 13, 2026 10:52 — with GitHub Actions Error

manerow had a problem deploying to test May 13, 2026 10:52 — with GitHub Actions Failure

manerow had a problem deploying to test May 13, 2026 10:52 — with GitHub Actions Error

github-actions Bot added the backend label May 13, 2026

manerow had a problem deploying to test May 13, 2026 11:33 — with GitHub Actions Error

manerow had a problem deploying to test May 13, 2026 12:43 — with GitHub Actions Error

manerow had a problem deploying to test May 13, 2026 12:43 — with GitHub Actions Failure

open-metadata deleted a comment from github-actions Bot May 13, 2026

manerow mentioned this pull request May 13, 2026

fix(dq-dashboard): denormalize certification onto testCase index + filter plumbing #28084

Merged

3 tasks

manerow had a problem deploying to test May 13, 2026 14:17 — with GitHub Actions Error

manerow force-pushed the fix/dq-cert-backend branch 3 times, most recently from 97b047e to ecc2413 Compare May 16, 2026 14:51

shah-harshit reviewed May 18, 2026

View reviewed changes

gitar-bot Bot reviewed May 18, 2026

View reviewed changes

Comment thread ...ata-ui/src/main/resources/ui/playwright/e2e/Features/DataQuality/CertificationFilter.spec.ts

manerow had a problem deploying to test May 18, 2026 07:06 — with GitHub Actions Failure

manerow had a problem deploying to test May 18, 2026 07:06 — with GitHub Actions Error

manerow had a problem deploying to test May 18, 2026 07:06 — with GitHub Actions Failure

shah-harshit previously approved these changes May 18, 2026

View reviewed changes

Base automatically changed from fix/dq-cert-backend to main May 18, 2026 07:19

manerow added 8 commits May 18, 2026 09:20

fix(dq-dashboard): add Certification filter dropdown and exclude it f…

aca2b91

…rom Tag dropdown

test(dq-dashboard): add Playwright coverage for the Certification filter

2c21469

fix(tag-page): route Tier/Certification tag pages through their dedic…

0110a64

…ated DQ filter keys

test(dq-dashboard): cover TagPage routing for Certification detail page

63859e2

chore(playwright): apply Prettier formatting to CertificationFilter spec

27f84b9

fix(dq-dashboard): make Certification search filter from the full opt…

25754bd

…ions list

test(dq-dashboard): cover independent Tier/Certification fetch gating

112e7d3

test(dq-dashboard): apply review feedback on CertificationFilter spec

deaa39b

manerow force-pushed the fix/dq-cert-ui branch from 7721a68 to deaa39b Compare May 18, 2026 07:20

manerow temporarily deployed to test May 18, 2026 07:30 — with GitHub Actions Inactive

shah-harshit approved these changes May 18, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dq-dashboard): add Certification filter dropdown to Data Quality dashboard#28085

fix(dq-dashboard): add Certification filter dropdown to Data Quality dashboard#28085
manerow wants to merge 8 commits into
mainfrom
fix/dq-cert-ui

manerow commented May 13, 2026 •

edited

Loading

Uh oh!

shah-harshit May 18, 2026

Uh oh!

manerow May 18, 2026

Uh oh!

shah-harshit May 18, 2026

Uh oh!

manerow May 18, 2026

Uh oh!

shah-harshit May 18, 2026

Uh oh!

manerow May 18, 2026

Uh oh!

shah-harshit May 18, 2026

Uh oh!

manerow May 18, 2026

Uh oh!

Uh oh!

gitar-bot Bot commented May 18, 2026 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented May 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	const certTable = new TableClass();
	let certTable:TableClass;
	let cert: TagClass;

Conversation

manerow commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What was wrong

What this PR changes

Depends on

Scope

Test plan

Follow-ups

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gitar-bot Bot commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented May 18, 2026

Quality Gate passed for 'open-metadata-ui'

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

manerow commented May 13, 2026 •

edited

Loading

gitar-bot Bot commented May 18, 2026 •

edited

Loading