Skip to content

fix(deps): remove explicit jersey version pins to inherit from BOM#28106

Open
yan-3005 wants to merge 2 commits into
mainfrom
fix/remove-explicit-jersey-version-pins
Open

fix(deps): remove explicit jersey version pins to inherit from BOM#28106
yan-3005 wants to merge 2 commits into
mainfrom
fix/remove-explicit-jersey-version-pins

Conversation

@yan-3005
Copy link
Copy Markdown
Contributor

Summary

Dependabot bumped explicit jersey version pins, but the root pom.xml already imports jersey-bom which manages all org.glassfish.jersey.* artifacts at 3.1.11. Explicit <version> entries override the BOM, causing those modules to resolve older versions than the rest of the project.

Fix: remove all explicit version pins for org.glassfish.jersey.* so every module inherits 3.1.11 from the BOM uniformly.

Module Artifact Was Now
openmetadata-sdk jersey-apache-connector 3.1.9 (explicit) 3.1.11 (BOM)
openmetadata-integration-tests jersey-client 3.1.9 (explicit) 3.1.11 (BOM)
openmetadata-integration-tests jersey-apache-connector 3.1.9 (explicit) 3.1.11 (BOM)

Also resolves #28000.

Verification

mvn -pl openmetadata-sdk,openmetadata-integration-tests dependency:tree \
  -Dincludes=org.glassfish.jersey.core:jersey-client,org.glassfish.jersey.connectors:jersey-apache-connector \
  | grep jersey
# Expected: all at 3.1.11

… BOM

jersey-client and jersey-apache-connector were pinned to 3.1.9 in
openmetadata-sdk and openmetadata-integration-tests. The root pom.xml
jersey-bom already manages all org.glassfish.jersey.* artifacts at 3.1.11.
Removing the explicit pins lets both modules inherit 3.1.11 from the BOM,
consistent with the rest of the project.
Copilot AI review requested due to automatic review settings May 14, 2026 06:43
@yan-3005 yan-3005 added safe to test Add this label to run secure Github workflows on PRs java Pull requests that update Java code vulnerabilities To release Will cherry-pick this PR into the release branch backend dependencies Pull requests that update a dependency file labels May 14, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes explicit <version> pins on org.glassfish.jersey.* artifacts in two modules so they inherit version 3.1.11 from the root jersey-bom import, restoring uniform Jersey versions across the project.

Changes:

  • Drop explicit 3.1.9 pin on jersey-apache-connector in openmetadata-sdk.
  • Drop explicit 3.1.9 pins on jersey-client and jersey-apache-connector in openmetadata-integration-tests.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
openmetadata-sdk/pom.xml Removes explicit version on jersey-apache-connector to inherit BOM-managed 3.1.11.
openmetadata-integration-tests/pom.xml Removes explicit versions on jersey-client and jersey-apache-connector to inherit BOM-managed 3.1.11.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

🔴 Playwright Results — 1 failure(s), 16 flaky

✅ 4053 passed · ❌ 1 failed · 🟡 16 flaky · ⏭️ 103 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 299 0 0 4
🔴 Shard 2 741 1 8 25
🟡 Shard 3 780 0 4 7
✅ Shard 4 790 0 0 18
🟡 Shard 5 708 0 1 41
🟡 Shard 6 735 0 3 8

Genuine Failures (failed on all attempts)

Features/Glossary/GlossaryWorkflow.spec.ts › should display correct status badge color and icon (shard 2)
Error: �[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoHaveText�[2m(�[22m�[32mexpected�[39m�[2m)�[22m failed

Locator:  locator('[data-row-key*="StatusBadgeTerm1778820932816"]').locator('.status-badge')
Expected: �[32m"Draft"�[39m
Received: �[31m"In Review"�[39m
Timeout:  15000ms

Call log:
�[2m  - Expect "toHaveText" with timeout 15000ms�[22m
�[2m  - waiting for locator('[data-row-key*="StatusBadgeTerm1778820932816"]').locator('.status-badge')�[22m
�[2m    18 × locator resolved to <div class="status-badge inReview" data-testid=""PW%'9443ceca.Gentle7a101676".StatusBadgeTerm1778820932816-status">…</div>�[22m
�[2m       - unexpected value "In Review"�[22m

🟡 16 flaky test(s) (passed on retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/BulkImport.spec.ts › Database (shard 2, 1 retry)
  • Features/BulkImport.spec.ts › Keyboard Delete selection (shard 2, 1 retry)
  • Features/Glossary/LargeGlossaryPerformance.spec.ts › should search and filter glossary terms (shard 2, 1 retry)
  • Features/KnowledgeCenterList.spec.ts › Knowledge Center List - Test infinite scroll/pagination (shard 2, 1 retry)
  • Features/KnowledgeCenterTextEditor.spec.ts › Rich Text Editor - Text Formatting (shard 2, 1 retry)
  • Features/KnowledgeCenterTextEditor.spec.ts › Rich Text Editor - Text Formatting (shard 2, 1 retry)
  • Features/KnowledgeCenterTextEditor.spec.ts › Rich Text Editor - Text Formatting (shard 2, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Features/SettingsNavigationPage.spec.ts › should save changes and navigate when "Save changes" is clicked in blocker (shard 3, 1 retry)
  • Features/UserProfileOnlineStatus.spec.ts › Should show "Active recently" for users active within last hour (shard 3, 1 retry)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
  • Pages/ExplorePageRightPanel_KnowledgeCenter.spec.ts › Should remove user owner for knowledgeCenter (shard 5, 2 retries)
  • Pages/Lineage/DataAssetLineage.spec.ts › Column lineage for mlModel -> mlModel (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 15, 2026

Code Review ✅ Approved

Removes explicit Jersey version pins to ensure uniform resolution to 3.1.11 via the project BOM. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend dependencies Pull requests that update a dependency file java Pull requests that update Java code safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch vulnerabilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants