Skip to content

Fixes 27433 - added changes related to task navigation#28116

Closed
satender-kumar-collate wants to merge 1 commit into
open-metadata:1.12.9from
satender-kumar-collate:task/navigation/1.12.9
Closed

Fixes 27433 - added changes related to task navigation#28116
satender-kumar-collate wants to merge 1 commit into
open-metadata:1.12.9from
satender-kumar-collate:task/navigation/1.12.9

Conversation

@satender-kumar-collate
Copy link
Copy Markdown
Contributor

@satender-kumar-collate satender-kumar-collate commented May 14, 2026

Describe your changes:

Fixes #27433
Added changes related to task navigation from notifications feed.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Tests:

Unit tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

  • PowerBI Connector:
    • Added handling for empty or special characters in entity names within PowerBIConnector.
    • Updated parsing logic to ensure robustness when encountering unexpected entity naming conventions.

This will update automatically on new commits.

@satender-kumar-collate satender-kumar-collate requested a review from a team as a code owner May 14, 2026 14:08
@satender-kumar-collate satender-kumar-collate added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels May 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ TypeScript Types Need Update

The generated TypeScript types are out of sync with the JSON schema changes.

Since this is a pull request from a forked repository, the types cannot be automatically committed.
Please generate and commit the types manually:

cd openmetadata-ui/src/main/resources/ui
./json2ts-generate-all.sh -l true
git add src/generated/
git commit -m "Update generated TypeScript types"
git push

After pushing the changes, this check will pass automatically.

@github-actions
Copy link
Copy Markdown
Contributor

❌ UI Checkstyle Failed

❌ ESLint + Prettier + Organise Imports (src)

One or more source files have linting or formatting issues.

❌ Core Components — ESLint + Prettier

One or more core-component files have linting or formatting issues.


Fix locally (fast — only checks files changed in this branch):

make ui-checkstyle-changed

@github-actions
Copy link
Copy Markdown
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@satender-kumar-collate satender-kumar-collate deleted the task/navigation/1.12.9 branch May 15, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant