ast: don't leak generated locals in ref type errors#8902
Open
sspaink wants to merge 1 commit into
Open
Conversation
When a reference has a composite subject (e.g. [1, 2][i]) or a dynamic
index term (e.g. [1, 2][input.x]), the compiler hoists that part of the
ref into a generated local. Previously these locals leaked verbatim into
type errors, e.g.:
undefined ref: __localq0__[i][j]
The type checker's var rewriter only knew how to map user variables back
(via RewrittenVars), so anonymous generated locals were rendered as-is.
Record a mapping from each generated ref-subject/dynamic-operand local
back to the original term value (in localVarGenerator.subjects) and use
it when rendering refs in type errors, so the original expression is
shown instead:
undefined ref: [1, 2][i][j]
Fixes open-policy-agent#8897
Signed-off-by: Sebastian Spaink <sebastianspaink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8897
When a reference has a composite subject (e.g. [1, 2][i]) or a dynamic index term (e.g. [1, 2][input.x]), the compiler hoists that part of the ref into a generated local. Previously these locals leaked verbatim into type errors, e.g.:
The type checker's var rewriter only knew how to map user variables back (via RewrittenVars), so anonymous generated locals were rendered as-is.
Record a mapping from each generated ref-subject/dynamic-operand local back to the original term value (in localVarGenerator.subjects) and use it when rendering refs in type errors, so the original expression is shown instead: