Standardize OkHttpHttpSender shutdown to await executor termination#8495
Draft
thswlsqls wants to merge 1 commit into
Draft
Standardize OkHttpHttpSender shutdown to await executor termination#8495thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (73.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8495 +/- ##
============================================
- Coverage 78.77% 78.76% -0.01%
- Complexity 8579 8580 +1
============================================
Files 1009 1009
Lines 28993 29006 +13
Branches 3599 3600 +1
============================================
+ Hits 22839 22848 +9
- Misses 5311 5314 +3
- Partials 843 844 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8280
Description
OkHttpHttpSender.shutdown()with the siblingOkHttpGrpcSender.shutdown()in the same package, which Standardize sender shutdown implementations #8280 designates as the reference implementation.dispatcher().cancelAll(), thenconnectionPool().evictAll(), then (for a managed executor)executorService.shutdownNow().okhttp-shutdownthread callsawaitTermination(5, SECONDS), logs a WARNING on timeout, and completes the returnedCompletableResultCode. A non-managed executor still returnsCompletableResultCode.ofSuccess().io.opentelemetry.exporter.sender.okhttp.internal); no public API change, no apidiff, no CHANGELOG entry.Testing done
OkHttpHttpSenderTestshutdown tests mirroringOkHttpGrpcSenderTest:shutdown_CompletableResultCodeShouldWaitForThreads,shutdown_NonManagedExecutor_ReturnsImmediately,shutdown_ExecutorDoesNotTerminateInTime_LogsWarningButSucceeds,shutdown_InterruptedWhileWaiting_StillSucceeds../gradlew :exporters:sender:okhttp:checkpassed (5 tests, 0 failures).