modified disable internet function, allows for container specific blockers#62
Merged
ryanka-openai merged 2 commits intomainfrom Aug 14, 2025
Merged
modified disable internet function, allows for container specific blockers#62ryanka-openai merged 2 commits intomainfrom
ryanka-openai merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed how disable_internet works.
When a container is created, a new chain is made with the container id, and a jump rule is added to DOCKER-USER. Requests from this container then jump to this new chain, where specific rule blockers can be added. Upon teardown both the jump rule and the new chain are completely cleared. If somehow they are not cleared, functionality of any other container shouldn't change, since both the bridge_id and the ctr_ip have to match for a packet to be jumped.
When disable_internet is called, the rules originally created by add_weak_network_block_via_ip_tables are now spread across both _populate_ctr_chain and _ensure_input_block. The function _populate_ctr_chain adds rules to the container id specific chain, while _ensure_input_block applies the same INPUT rules as add_weak_network_block_via_ip_tables, except it has been modified to do the same bridge_id and ctr_ip matching (which allows for differing internet blocking rules between containers).
Calling disable_internet is the same on a specific container basis, but these changes allow multiple containers to be run in parallel or sequence on the same host machine without conflicting rules.