Skip to content

[swel] Remove RunnerArgs instance and update readme/tests #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thesofakillers merged 1 commit into from
Aug 28, 2025
Merged

[swel] Remove RunnerArgs instance and update readme/tests #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions project/swelancer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ uv run python swelancer/run_swelancer.py \
runner.experimental_use_multiprocessing=False \
runner.enable_slackbot=False \
runner.recorder=nanoeval.recorder:dummy_recorder \
runner.max_retries=3
runner.max_retries=2
```

Same as above but for a single issue (e.g., `28565_1001`):
Expand All @@ -144,7 +144,7 @@ uv run python swelancer/run_swelancer.py \
runner.experimental_use_multiprocessing=False \
runner.enable_slackbot=False \
runner.recorder=nanoeval.recorder:dummy_recorder \
runner.max_retries=3
runner.max_retries=2
```

We've implemented a
Expand Down Expand Up @@ -175,7 +175,7 @@ uv run python swelancer/run_swelancer.py \
runner.experimental_use_multiprocessing=False \
runner.enable_slackbot=False \
runner.recorder=nanoeval.recorder:dummy_recorder \
runner.max_retries=3
runner.max_retries=2
```

To run manager tasks, set `swelancer.task_type=swe_manager`. Currently,
Expand All @@ -201,7 +201,7 @@ uv run python swelancer/run_swelancer.py \
runner.experimental_use_multiprocessing=False \
runner.enable_slackbot=False \
runner.recorder=nanoeval.recorder:dummy_recorder \
runner.max_retries=3
runner.max_retries=2
```

### Logging
Expand Down
11 changes: 1 addition & 10 deletions project/swelancer/swelancer/run_swelancer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import nanoeval
from nanoeval.eval import EvalSpec, RunnerArgs
from nanoeval.library_config import LibraryConfig
from nanoeval.recorder import dummy_recorder
from nanoeval.setup import nanoeval_entrypoint
from swelancer.eval import SWELancerEval
from swelancer.utils.custom_logging import (
Expand All @@ -16,18 +15,10 @@
swelancer_library_config as default_library_config,
)

default_runner = RunnerArgs(
concurrency=20,
experimental_use_multiprocessing=False,
enable_slackbot=False,
recorder=dummy_recorder(),
max_retries=0,
)


async def main(
swelancer: SWELancerEval,
runner: RunnerArgs = default_runner,
runner: RunnerArgs,
library_config: LibraryConfig = default_library_config,
) -> None:
setup_logging(library_config)
Expand Down
2 changes: 1 addition & 1 deletion project/swelancer/tests/integration/test_dummy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ async def test_gold_patch_passes_tests_using_local_cluster(issue_id: str) -> Non
experimental_use_multiprocessing=False,
enable_slackbot=False,
recorder=dummy_recorder(),
max_retries=0,
max_retries=2,
)

solver = DummySolver(
Expand Down