fix: #1190 reconcile streamed function calls when server-managed runs abort#1241
Merged
fix: #1190 reconcile streamed function calls when server-managed runs abort#1241
Conversation
🦋 Changeset detectedLatest commit: 2db3d00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves #1190 by fixing server-managed streaming runs that abort after the model has streamed a function call but before the SDK can execute the tool and submit its result.
The change adds an internal stream-abort reconciliation helper for
@openai/agents-corethat tracks streamedresponse.createdandresponse.output_item.doneevents, builds incomplete syntheticfunction_call_resultitems for pending function calls, and submits them on abort or consumer cancellation without reusing the aborted signal. This keeps bothconversationIdandpreviousResponseIdcontinuation paths usable after mid-tool-call stream cancellation.